Bug 173481 – Include a few widespread WTF headers in WebCorePrefix.h

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Include a few widespread WTF headers in WebCorePrefix.h

[Tim Horton]

Created attachment 313094 [details]
Patch

[Build Bot]

Attachment 313094 [details] did not pass style-queue:


ERROR: Source/WebCore/WebCorePrefix.h:167:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

https://trac.webkit.org/changeset/218402/webkit

[Tim Horton]

Build fix in https://trac.webkit.org/changeset/218404/webkit

[WebKit Commit Bot]

Re-opened since this is blocked by bug 173494

[Tim Horton]

Ooh! I can reproduce the build failure by building with dSYMs enabled:

./Tools/Scripts/build-webkit --release ARCHS=x86_64 DEBUG_INFORMATION_FORMAT=dwarf-with-dsym

    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/dsymutil /Build/Release/WebCore.framework/Versions/A/WebCore -o /Build/Release/WebCore.framework.dSYM
LLVM ERROR: IO failure on output stream.
Command /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/dsymutil failed with exit code 1

[Tim Horton]

Adding WTFString or Optional by themselves seems to have the same effect

[Tim Horton]

Ditto for StdLibExtras...

[Simon Fraser (smfr)]

How big is the dSYM file before your changes?

[Tim Horton]

1.4GB

[Tim Horton]

It's not about size. I've reduced it down and can reproduce even by just adding:

namespace WTF {

}

to the same spot

[Tim Horton]

I filed https://bugs.llvm.org/show_bug.cgi?id=33520

[Tim Horton]

<rdar://problem/34784096>

[Tim Horton]

Created attachment 322568 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 322568 [details]
Patch

Clearing flags on attachment: 322568

Committed r222810: <http://trac.webkit.org/changeset/222810>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Matt Lewis]

This broke the windows build:

https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/4908

error:

c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\WebCorePrefix.h(171): fatal error C1083: Cannot open type library file: 'c:\cygwin\home\buildbot\slave\win-release\build\webkitbuild\release\derivedsources\forwardingheaders\wtf\fastmalloc.h': Error loading type library/DLL. [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]

[Tim Horton]

On our build bots, this looks like a ~6-7% win, not 9%, but still a decent win. We should do something similar in WebKit and JSC, probably.

[Tim Horton]

(In reply to Tim Horton from comment #18)
> On our build bots, this looks like a ~6-7% win, not 9%, but still a decent
> win. We should do something similar in WebKit and JSC, probably.

6-7% on WebCore alone, less if you measure the whole project :(