Make some WebRTC tests easier to debug when failing
Created attachment 313091 [details] Patch
Comment on attachment 313091 [details] Patch Clearing flags on attachment: 313091 Committed r218408: <http://trac.webkit.org/changeset/218408>
All reviewed patches have been landed. Closing bug.
This revision seems to have caused test that were previously either flaky timeouts or passing to start failing on release builds according to the Flakiness Dashboard https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r218500%20(2468)/results.html Test that have become flaky: webrtc/datachannel/basic-tcp.html [Failure] webrtc/datachannel/basic.html [Failure] webrtc/datachannel/datachannel-gc.html [Timeout] https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fdatachannel%2Fbasic-tcp.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fdatachannel%2Fbasic.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fdatachannel%2Fdatachannel-gc.html
Reopening to attach new patch.
Created attachment 313331 [details] Patch
I fixed some test expectations in the patch that gets committed. (In reply to Matt Lewis from comment #4) > This revision seems to have caused test that were previously either flaky > timeouts or passing to start failing on release builds according to the > Flakiness Dashboard > > https://build.webkit.org/results/ > Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r218500%20(2468)/results.html > > > Test that have become flaky: > webrtc/datachannel/basic-tcp.html [Failure] > webrtc/datachannel/basic.html [Failure] > webrtc/datachannel/datachannel-gc.html [Timeout] > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=webrtc%2Fdatachannel%2Fbasic-tcp.html > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=webrtc%2Fdatachannel%2Fbasic.html > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=webrtc%2Fdatachannel%2Fdatachannel-gc.html
Comment on attachment 313331 [details] Patch Rejecting attachment 313331 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 313331, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 218508 = f69b9419e43c98d8b95e3f4028f4d67efcb18a5a r218509 = 09b0a7779144f6998d359b0f7d1c9163eeba68d8 r218510 = 50bd1d913eae75df3b16b29fd32ffc894cb78c1f r218511 = 7eb47a5221ac9b3dac68e44b1e453aec40667bdb Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3962458