Bug 173470 - REGRESSION(r166799): LogsPageMessagesToSystemConsoleEnabled corrupts non-ASCII characters
Summary: REGRESSION(r166799): LogsPageMessagesToSystemConsoleEnabled corrupts non-ASCI...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-16 08:22 PDT by Konstantin Tokarev
Modified: 2017-06-16 09:08 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.65 KB, patch)
2017-06-16 08:24 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2017-06-16 08:22:13 PDT 
ConsoleClient::printConsoleMessageWithArguments() incorrectly uses const char* overload of StringBuilder::append() that assummes Latin1 encoding, not UTF8
Comment 1 Konstantin Tokarev 2017-06-16 08:23:51 PDT 
Before r166799 this code used

    printf(" %s", argAsString.utf8().data());

that was correct.
Comment 2 Konstantin Tokarev 2017-06-16 08:24:21 PDT 
Created attachment 313076 [details]
Patch
Comment 3 WebKit Commit Bot 2017-06-16 09:08:34 PDT 
Comment on attachment 313076 [details]
Patch

Clearing flags on attachment: 313076

Committed r218392: <http://trac.webkit.org/changeset/218392>
Comment 4 WebKit Commit Bot 2017-06-16 09:08:36 PDT 
All reviewed patches have been landed.  Closing bug.