Bug 173462 - Handle timeout of prepareForPictureInPictureStopWithCompletionHandler.
Summary: Handle timeout of prepareForPictureInPictureStopWithCompletionHandler.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-16 02:43 PDT by Jeremy Jones
Modified: 2017-11-02 11:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.63 KB, patch)
2017-06-16 02:48 PDT, Jeremy Jones 		jer.noble: review+
Details | Formatted Diff | Diff
Patch for landing. (5.63 KB, patch)
2017-06-16 14:22 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-06-16 02:43:29 PDT 
Handle timeout of prepareForPictureInPictureStopWithCompletionHandler.
Comment 1 Jeremy Jones 2017-06-16 02:44:25 PDT 
rdar://problem/32128170
Comment 2 Jeremy Jones 2017-06-16 02:48:28 PDT 
Created attachment 313066 [details]
Patch
Comment 3 Jer Noble 2017-06-16 12:50:34 PDT 
Comment on attachment 313066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313066&action=review

Looks good; just a couple of tiny nits.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:918
> -
> +    

Whitespace.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:957
> -
> +        

Whitespace.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1004
> -    LOG(Fullscreen, "WebVideoFullscreenInterfaceAVKit::watchdogTimerFired(%p) - no exit fullscreen response in %gs; forcing fullscreen hidden.", this, defaultWatchdogTimerInterval);
> +    LOG(Fullscreen, "WebVideoFullscreenInterfaceAVKit::watchdogTimerFired(%p) - no exit fullscreen; forcing fullscreen hidden.", this);

Is this intentional?
Comment 4 Jeremy Jones 2017-06-16 13:06:49 PDT 
(In reply to Jer Noble from comment #3)
> Comment on attachment 313066 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313066&action=review
> 
> Looks good; just a couple of tiny nits.
> 
> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:918
> > -
> > +    
> 
> Whitespace.
> 
> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:957
> > -
> > +        
> 
> Whitespace.
> 
> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1004
> > -    LOG(Fullscreen, "WebVideoFullscreenInterfaceAVKit::watchdogTimerFired(%p) - no exit fullscreen response in %gs; forcing fullscreen hidden.", this, defaultWatchdogTimerInterval);
> > +    LOG(Fullscreen, "WebVideoFullscreenInterfaceAVKit::watchdogTimerFired(%p) - no exit fullscreen; forcing fullscreen hidden.", this);
> 
> Is this intentional?

I put this back in, but did defaultWatchdogTimerInterval.value() to convert to a double.
Comment 5 Jeremy Jones 2017-06-16 14:22:14 PDT 
Created attachment 313132 [details]
Patch for landing.
Comment 6 WebKit Commit Bot 2017-06-16 15:56:48 PDT 
Comment on attachment 313132 [details]
Patch for landing.

Clearing flags on attachment: 313132

Committed r218422: <http://trac.webkit.org/changeset/218422>