Bug 173462 – Handle timeout of prepareForPictureInPictureStopWithCompletionHandler.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jeremy Jones]

Handle timeout of prepareForPictureInPictureStopWithCompletionHandler.

[Jeremy Jones]

rdar://problem/32128170

[Jeremy Jones]

Created attachment 313066 [details]
Patch

[Jer Noble]

Comment on attachment 313066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313066&action=review

Looks good; just a couple of tiny nits.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:918
> -
> +    

Whitespace.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:957
> -
> +        

Whitespace.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1004
> -    LOG(Fullscreen, "WebVideoFullscreenInterfaceAVKit::watchdogTimerFired(%p) - no exit fullscreen response in %gs; forcing fullscreen hidden.", this, defaultWatchdogTimerInterval);
> +    LOG(Fullscreen, "WebVideoFullscreenInterfaceAVKit::watchdogTimerFired(%p) - no exit fullscreen; forcing fullscreen hidden.", this);

Is this intentional?

[Jeremy Jones]

(In reply to Jer Noble from comment #3)
> Comment on attachment 313066 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313066&action=review
> 
> Looks good; just a couple of tiny nits.
> 
> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:918
> > -
> > +    
> 
> Whitespace.
> 
> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:957
> > -
> > +        
> 
> Whitespace.
> 
> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1004
> > -    LOG(Fullscreen, "WebVideoFullscreenInterfaceAVKit::watchdogTimerFired(%p) - no exit fullscreen response in %gs; forcing fullscreen hidden.", this, defaultWatchdogTimerInterval);
> > +    LOG(Fullscreen, "WebVideoFullscreenInterfaceAVKit::watchdogTimerFired(%p) - no exit fullscreen; forcing fullscreen hidden.", this);
> 
> Is this intentional?

I put this back in, but did defaultWatchdogTimerInterval.value() to convert to a double.

[Jeremy Jones]

Created attachment 313132 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 313132 [details]
Patch for landing.

Clearing flags on attachment: 313132

Committed r218422: <http://trac.webkit.org/changeset/218422>