RESOLVED FIXED 173438
Web Inspector: Search highlight doesn't show up in resources when paused 
https://bugs.webkit.org/show_bug.cgi?id=173438
Summary Web Inspector: Search highlight doesn't show up in resources when paused
Joseph Pecoraro
Reported 2017-06-15 14:24:10 PDT
Summary: Search highlight doesn't show up in resources when paused Steps to reproduce: 1. Inspect <http://bogojoker.com/shell/> 2. Set a breakpoint on: easySlider.min.js:56:21 3. Trigger pause (by clicking down arrow on the page) 4. Global Search for "empty" 5. Click on results in jquery => No highlight Notes: - TextEditor.js bails in highlighting if paused and !executionLineNumber. That seems wrong.
Attachments
[PATCH] Proposed Fix (2.02 KB, patch)
2017-06-15 14:28 PDT, Joseph Pecoraro 		mattbaker: review+
DetailsFormatted DiffDiff
[PATCH] For Landing (2.02 KB, patch)
2017-06-15 14:35 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-06-15 14:24:29 PDT
<rdar://problem/32800114>
Joseph Pecoraro
Comment 2 2017-06-15 14:28:03 PDT
Created attachment 313006 [details] [PATCH] Proposed Fix
Matt Baker
Comment 3 2017-06-15 14:34:25 PDT
Comment on attachment 313006 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=313006&action=review r=me with a nit > Source/WebInspectorUI/ChangeLog:13 > + not have the active callframe. Relax this and make it match the intended behavior Correct grammar: "that not have" -> "that does not have"
Joseph Pecoraro
Comment 4 2017-06-15 14:35:48 PDT
Created attachment 313009 [details] [PATCH] For Landing
WebKit Commit Bot
Comment 5 2017-06-15 14:50:40 PDT
Comment on attachment 313009 [details] [PATCH] For Landing Clearing flags on attachment: 313009 Committed r218359: <http://trac.webkit.org/changeset/218359>
Note You need to log in before you can comment on or make changes to this bug.