Bug 173438 - Web Inspector: Search highlight doesn't show up in resources when paused
Summary: Web Inspector: Search highlight doesn't show up in resources when paused
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-15 14:24 PDT by Joseph Pecoraro
Modified: 2017-06-15 15:33 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.02 KB, patch)
2017-06-15 14:28 PDT, Joseph Pecoraro
mattbaker: review+
Details | Formatted Diff | Diff
[PATCH] For Landing (2.02 KB, patch)
2017-06-15 14:35 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-06-15 14:24:10 PDT
Summary:
Search highlight doesn't show up in resources when paused

Steps to reproduce:
1. Inspect <http://bogojoker.com/shell/>
2. Set a breakpoint on: easySlider.min.js:56:21
3. Trigger pause (by clicking down arrow on the page)
4. Global Search for "empty"
5. Click on results in jquery
  => No highlight

Notes:
- TextEditor.js bails in highlighting if paused and !executionLineNumber. That seems wrong.
Comment 1 Radar WebKit Bug Importer 2017-06-15 14:24:29 PDT
<rdar://problem/32800114>
Comment 2 Joseph Pecoraro 2017-06-15 14:28:03 PDT
Created attachment 313006 [details]
[PATCH] Proposed Fix
Comment 3 Matt Baker 2017-06-15 14:34:25 PDT
Comment on attachment 313006 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=313006&action=review

r=me with a nit

> Source/WebInspectorUI/ChangeLog:13
> +        not have the active callframe. Relax this and make it match the intended behavior

Correct grammar: "that not have" -> "that does not have"
Comment 4 Joseph Pecoraro 2017-06-15 14:35:48 PDT
Created attachment 313009 [details]
[PATCH] For Landing
Comment 5 WebKit Commit Bot 2017-06-15 14:50:40 PDT
Comment on attachment 313009 [details]
[PATCH] For Landing

Clearing flags on attachment: 313009

Committed r218359: <http://trac.webkit.org/changeset/218359>