Bug 173437 – Web Inspector: Add small delay before showing the progress spinner when loading resources

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

For small and quickly loading files, it is annoying to see the IndeterminateProgressSpinner briefly appear before being removed almost immediately.

[Devin Rousso]

Created attachment 313014 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 313014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313014&action=review

> Source/WebInspectorUI/ChangeLog:13
> +        Delay the creation of the spinner for 100ms.  If the content is available before then, just
> +        clear the timeout and the spinner will never be created/shown.

I know I suggested 100ms, but lets try to arrive at this with more data.

What is the average amount of time it takes for the frontend to load an image when inspecting (1) locally and (2) remotely.

Testing with your Mac Retina laptop should good. I can get you an iOS device to test with.

Once we have that average / bucketed histogram we can provide justification for this currently magic value.

[Devin Rousso]

Created attachment 313027 [details]
Patch

[Nikita Vasilyev]

Comment on attachment 313027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313027&action=review

> Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:50
> +        console.time("Resource");

This shouldn't be in the patch.

[Joseph Pecoraro]

Comment on attachment 313027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313027&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:40
> +            // Append a spinner while waiting for contentAvailable. The subclasses are responsible

Nit: "The subclasses are" => "Subclasses are"

You can also say in the comment "... by calling removeLoadingIndicator".

> Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:46
> +        }, 50);

Lets make this 100 to match the ChangeLog.

[Devin Rousso]

Created attachment 314288 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 314288 [details]
Patch

Clearing flags on attachment: 314288

Committed r219017: <http://trac.webkit.org/changeset/219017>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.