This way, we can be sure we've got every JSRunLoopTimer instance covered if we need to change their run loop (e.g. when setting to the WebThread's run loop). <rdar://problem/31287961>
Created attachment 313017 [details] proposed patch.
Comment on attachment 313017 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=313017&action=review r=me > Source/JavaScriptCore/runtime/VM.h:681 > + void registerRunLoop(JSRunLoopTimer*); > + void unregisterRunLoop(JSRunLoopTimer*); Can we rename these to registerRunLoopTimer and unregisterRunLoopTimer?
(In reply to Filip Pizlo from comment #2) > > Source/JavaScriptCore/runtime/VM.h:681 > > + void registerRunLoop(JSRunLoopTimer*); > > + void unregisterRunLoop(JSRunLoopTimer*); > > Can we rename these to registerRunLoopTimer and unregisterRunLoopTimer? Will fix.
Comment on attachment 313017 [details] proposed patch. Attachment 313017 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3937930 Number of test failures exceeded the failure limit.
Created attachment 313024 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
The test failures look legit. I will investigate.
(In reply to Mark Lam from comment #6) > The test failures look legit. I will investigate. Found it. In unregisterRunLoopTimer(), I was asserting the opposite of what it's supposed to be. Fixed and let's retest on the EWS.
Created attachment 313032 [details] patch for landing.
Comment on attachment 313032 [details] patch for landing. Clearing flags on attachment: 313032 Committed r218381: <http://trac.webkit.org/changeset/218381>
All reviewed patches have been landed. Closing bug.