Bug 173428 - [cmake] ADD_PRECOMPILED_HEADER should append OBJECT_DEPENDS, not overwrite it
Summary: [cmake] ADD_PRECOMPILED_HEADER should append OBJECT_DEPENDS, not overwrite it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-15 12:25 PDT by Konstantin Tokarev
Modified: 2017-06-15 14:36 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.77 KB, patch)
2017-06-15 12:30 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2017-06-15 12:25:55 PDT 
Right now, if any of source files that are passed to ADD_PRECOMPILED_HEADER have non-empty OBJECT_DEPENDS property (e.g. changed with ADD_SOURCE_DEPENDENCIES call), its value is lost.
Comment 1 Konstantin Tokarev 2017-06-15 12:30:13 PDT 
Created attachment 312999 [details]
Patch
Comment 2 Konstantin Tokarev 2017-06-15 14:35:59 PDT 
Comment on attachment 312999 [details]
Patch

Clearing flags on attachment: 312999

Committed r218357: <http://trac.webkit.org/changeset/218357>
Comment 3 Konstantin Tokarev 2017-06-15 14:36:04 PDT 
All reviewed patches have been landed.  Closing bug.