fast/canvas/canvas-createPattern-video-loading.html [ Failure ]
The test fails because drawImageToCanvasAndCheckPixels only find transparent black on the canvas when called from the "playing" callback. The issue is that MediaPlayerPrivateGStreamerBase::m_sample is set to nullptr in the newly added flushCurrentBuffer() method, called in response to a GST_EVENT_FLUSH_START event. The paint() method then returns early because GST_IS_SAMPLE(m_sample.get()) is false, and the CanvasPattern ends up transparent black.
This started failing recently in Wayland and WPE as well: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcanvas%2Fcanvas-createPattern-video-modify.html
Ah, sorry. Different test. :/
(In reply to Ms2ger from comment #1) > The test fails because drawImageToCanvasAndCheckPixels only find transparent > black on the canvas when called from the "playing" callback. > > The issue is that MediaPlayerPrivateGStreamerBase::m_sample is set to > nullptr in the newly added flushCurrentBuffer() method, called in response > to a GST_EVENT_FLUSH_START event. The paint() method then returns early > because GST_IS_SAMPLE(m_sample.get()) is false, and the CanvasPattern ends > up transparent black. Yes and because no texture copy is done when flushing the sample. The m_platformLayerProxy->dropCurrentBufferWhilePreservingTexture() call has no effect, because it's done outside of the texturemapper code path.
Created attachment 425097 [details] Patch
Committed r275755 (236333@main): <https://commits.webkit.org/236333@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425097 [details].