Bug 173402 - WebKit does not honor closed caption stroke width.
Summary: WebKit does not honor closed caption stroke width.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-15 00:32 PDT by Per Arne Vollan
Modified: 2017-06-16 07:17 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.89 KB, patch)
2017-06-15 00:36 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (5.34 KB, patch)
2017-06-15 02:10 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (3.23 KB, patch)
2017-06-15 06:30 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (2.75 KB, patch)
2017-06-16 03:43 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (3.15 KB, patch)
2017-06-16 04:18 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-06-15 00:32:21 PDT 
WebKit currently has an upper limit on the stroke width returned from MACaptionAppearanceCopyFontDescriptorWithStrokeForStyle. Also, the stroke width is currently calculated based on the font size in pixels, it should be calculated based on the font size in points.
Comment 1 Per Arne Vollan 2017-06-15 00:36:09 PDT 
Created attachment 312957 [details]
Patch
Comment 2 Per Arne Vollan 2017-06-15 02:10:54 PDT 
Created attachment 312964 [details]
Patch
Comment 3 Per Arne Vollan 2017-06-15 02:11:38 PDT 
rdar://problem/32761276
Comment 4 Per Arne Vollan 2017-06-15 06:30:49 PDT 
Created attachment 312975 [details]
Patch
Comment 5 Per Arne Vollan 2017-06-16 03:43:47 PDT 
Created attachment 313068 [details]
Patch
Comment 6 Per Arne Vollan 2017-06-16 04:18:24 PDT 
Created attachment 313069 [details]
Patch
Comment 7 Per Arne Vollan 2017-06-16 06:45:01 PDT 
Comment on attachment 313069 [details]
Patch

Thanks for reviewing, Eric!
Comment 8 WebKit Commit Bot 2017-06-16 07:17:02 PDT 
Comment on attachment 313069 [details]
Patch

Clearing flags on attachment: 313069

Committed r218388: <http://trac.webkit.org/changeset/218388>
Comment 9 WebKit Commit Bot 2017-06-16 07:17:04 PDT 
All reviewed patches have been landed.  Closing bug.