RESOLVED FIXED 173398
[WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients 
https://bugs.webkit.org/show_bug.cgi?id=173398
Summary [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording ...
Jer Noble
Reported 2017-06-14 19:19:13 PDT
[WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
Attachments
Patch (31.78 KB, patch)
2017-06-14 20:20 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (31.77 KB, patch)
2017-06-15 09:35 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (31.77 KB, patch)
2017-06-15 10:03 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (31.82 KB, patch)
2017-06-15 14:20 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (32.04 KB, patch)
2017-06-15 18:08 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (32.00 KB, patch)
2017-06-16 11:07 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-06-14 19:19:52 PDT
<rdar://problem/32592961>
Jer Noble
Comment 2 2017-06-14 20:20:14 PDT
Created attachment 312949 [details] Patch
Eric Carlson
Comment 3 2017-06-14 21:19:16 PDT
Comment on attachment 312949 [details] Patch Very nice!
Jer Noble
Comment 4 2017-06-15 09:35:54 PDT
Created attachment 312987 [details] Patch for landing
Jer Noble
Comment 5 2017-06-15 10:03:50 PDT
Created attachment 312988 [details] Patch for landing
Jer Noble
Comment 6 2017-06-15 14:20:14 PDT
Created attachment 313005 [details] Patch for landing
WebKit Commit Bot
Comment 7 2017-06-15 15:48:50 PDT
Comment on attachment 313005 [details] Patch for landing Clearing flags on attachment: 313005 Committed r218365: <http://trac.webkit.org/changeset/218365>
WebKit Commit Bot
Comment 8 2017-06-15 15:48:52 PDT
All reviewed patches have been landed. Closing bug.
Matt Lewis
Comment 10 2017-06-15 17:16:41 PDT
Reverted r218365 for reason: The revision caused API timeouts on all builds. Committed r218369: <http://trac.webkit.org/changeset/218369>
Jer Noble
Comment 11 2017-06-15 18:08:09 PDT
Created attachment 313036 [details] Patch for landing
Jer Noble
Comment 12 2017-06-15 18:11:29 PDT
(In reply to Jer Noble from comment #11) > Created attachment 313036 [details] > Patch for landing The only difference between this patch and the one that got rolled out is that we explicitly call configureTrackRendering() in MediaStreamTrack::stopTrack(). It was early returning in MediaStreamTrack::trackStopped() before it got to the configureTrackRendering() call.
WebKit Commit Bot
Comment 13 2017-06-15 19:49:43 PDT
Comment on attachment 313036 [details] Patch for landing Clearing flags on attachment: 313036 Committed r218375: <http://trac.webkit.org/changeset/218375>
WebKit Commit Bot
Comment 14 2017-06-15 19:49:44 PDT
All reviewed patches have been landed. Closing bug.
Matt Lewis
Comment 15 2017-06-16 10:36:24 PDT
After the patch, the API test WebKit2.MediaStreamTrackDetached is still timing out on all platforms. https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/2384/steps/run-api-tests/logs/stdio https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/2384 Spoke with Jer about timeout.
Matt Lewis
Comment 16 2017-06-16 10:40:57 PDT
Reverted r218375 for reason: The API test MediaStreamTrackDetached is still timing out after the patch Committed r218397: <http://trac.webkit.org/changeset/218397>
Jer Noble
Comment 17 2017-06-16 11:07:16 PDT
Created attachment 313093 [details] Patch for landing
Jer Noble
Comment 18 2017-06-16 11:07:57 PDT
This last patch enables mock capture devices for the test; this should address the test failing on bots (which do not have capture hardware) but passing on dev machines.
WebKit Commit Bot
Comment 19 2017-06-16 11:46:32 PDT
Comment on attachment 313093 [details] Patch for landing Clearing flags on attachment: 313093 Committed r218399: <http://trac.webkit.org/changeset/218399>
WebKit Commit Bot
Comment 20 2017-06-16 11:46:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.