Bug 173378 – [WK2][iOS] Remove dead-code "import "removed-dev-nodes.sb” from sandboxes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brent Fulgham]

For historical reasons, our sandboxes imported "removed-dev-nodes.sb”, which no longer does anything. Let's get rid of this useless import.

[Radar WebKit Bug Importer]

<rdar://problem/32773230>

[Brent Fulgham]

Note: instruments-support is also a no-op in 2017, so let's get rid of it, too.

[Brent Fulgham]

Created attachment 312914 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 312914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312914&action=review

> Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:-31
> -(import "removed-dev-nodes.sb")

Do we need any of those on iOS 10 still?

[Brent Fulgham]

(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 312914 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312914&action=review
> 
> > Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:-31
> > -(import "removed-dev-nodes.sb")
> 
> Do we need any of those on iOS 10 still?

No -- they haven't been needed since before iOS 10.

[Alexey Proskuryakov]

Comment on attachment 312914 [details]
Patch

Okay. So I take it "instruments-support is also a no-op in 2017" should read "instruments-support is also a no-op in 2016".

I'm curious about what change to make instruments-support unnecessary.

[Alexey Proskuryakov]

I'm curious about what change *made* instruments-support unnecessary.

[Brent Fulgham]

(In reply to Alexey Proskuryakov from comment #7)
> I'm curious about what change *made* instruments-support unnecessary.

They migrated the logic previously in "instruments-support" to the "debugging-support", function. Since that is triggered by "common-rules", which gets invoked when you import "common.sb", there was no need for a separate function.

[WebKit Commit Bot]

Comment on attachment 312914 [details]
Patch

Clearing flags on attachment: 312914

Committed r218292: <http://trac.webkit.org/changeset/218292>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.