Bug 173378 - [WK2][iOS] Remove dead-code "import "removed-dev-nodes.sb” from sandboxes
Summary: [WK2][iOS] Remove dead-code "import "removed-dev-nodes.sb” from sandboxes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-14 12:33 PDT by Brent Fulgham
Modified: 2017-06-14 14:06 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.02 KB, patch)
2017-06-14 12:49 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-06-14 12:33:24 PDT
For historical reasons, our sandboxes imported "removed-dev-nodes.sb”, which no longer does anything. Let's get rid of this useless import.
Comment 1 Radar WebKit Bug Importer 2017-06-14 12:33:41 PDT
<rdar://problem/32773230>
Comment 2 Brent Fulgham 2017-06-14 12:38:32 PDT
Note: instruments-support is also a no-op in 2017, so let's get rid of it, too.
Comment 3 Brent Fulgham 2017-06-14 12:49:06 PDT
Created attachment 312914 [details]
Patch
Comment 4 Alexey Proskuryakov 2017-06-14 13:06:40 PDT
Comment on attachment 312914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312914&action=review

> Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:-31
> -(import "removed-dev-nodes.sb")

Do we need any of those on iOS 10 still?
Comment 5 Brent Fulgham 2017-06-14 13:09:32 PDT
(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 312914 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312914&action=review
> 
> > Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:-31
> > -(import "removed-dev-nodes.sb")
> 
> Do we need any of those on iOS 10 still?

No -- they haven't been needed since before iOS 10.
Comment 6 Alexey Proskuryakov 2017-06-14 13:33:36 PDT
Comment on attachment 312914 [details]
Patch

Okay. So I take it "instruments-support is also a no-op in 2017" should read "instruments-support is also a no-op in 2016".

I'm curious about what change to make instruments-support unnecessary.
Comment 7 Alexey Proskuryakov 2017-06-14 13:45:12 PDT
I'm curious about what change *made* instruments-support unnecessary.
Comment 8 Brent Fulgham 2017-06-14 13:51:42 PDT
(In reply to Alexey Proskuryakov from comment #7)
> I'm curious about what change *made* instruments-support unnecessary.

They migrated the logic previously in "instruments-support" to the "debugging-support", function. Since that is triggered by "common-rules", which gets invoked when you import "common.sb", there was no need for a separate function.
Comment 9 WebKit Commit Bot 2017-06-14 14:06:43 PDT
Comment on attachment 312914 [details]
Patch

Clearing flags on attachment: 312914

Committed r218292: <http://trac.webkit.org/changeset/218292>
Comment 10 WebKit Commit Bot 2017-06-14 14:06:44 PDT
All reviewed patches have been landed.  Closing bug.