Bug 173368 - [GTK][WPE] Raise the timeout values for layout tests
Summary: [GTK][WPE] Raise the timeout values for layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-14 08:47 PDT by Carlos Alberto Lopez Perez
Modified: 2017-06-14 10:59 PDT (History)
11 users (show)

See Also:


Attachments
Patch (8.20 KB, patch)
2017-06-14 09:51 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-06-14 08:47:21 PDT
GTK+ debug test bots are constantly giving exit early errors (many times related to timeouts) and on the release test bot that also happens sometimes.
And the release test bot is running test with high priority to avoid random timeouts that would happen otherwise.

I have been checking the timeout values for all ports.

It turns out this is the current status quo:


 - Mac/iOS: They use a 30 second timeout (both for Release and Debug). A special case of 35 seconds is used for the case of the guard_malloc builds.
 - GTK+: It uses 6 seconds for release and 12 for debug. A special case of 10x seconds is used for the case of running under Valgrind.
 - WPE: It uses 6 seconds for both release and debug (There isn't currently any debug test bot for the WPE port)


I couldn't find any explanation for this difference other than r121497 <https://trac.webkit.org/r121497> where the Chromium port defined a 6/12 timeout for release/debug and they defined a default for all other ports of 35 seconds. This general 35 seconds was then lowered to 30 in r177471 <https://trac.webkit.org/r177471>.

I have been thinking between just using the default 30 seconds value like Mac/iOS ports are doing or to raise our values a bit.

Currently I'm leaning towards raising our values to have a 30 seconds for debug and 15 seconds for release. Debug builds are much slower, it makes sense to have higher timeouts.
Comment 1 Carlos Alberto Lopez Perez 2017-06-14 09:51:01 PDT
Created attachment 312896 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2017-06-14 10:59:03 PDT
Comment on attachment 312896 [details]
Patch

Clearing flags on attachment: 312896

Committed r218270: <http://trac.webkit.org/changeset/218270>
Comment 3 Carlos Alberto Lopez Perez 2017-06-14 10:59:07 PDT
All reviewed patches have been landed.  Closing bug.