Bug 173362 – Add API::InjectedBundle::ResourceLoadClient

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

It will be used by the GTK+ port instead of the C API. This is the last one we need to get rid of the C API in the GTK+ implementation.

[Carlos Garcia Campos]

Created attachment 312884 [details]
Patch

[Alex Christensen]

Comment on attachment 312884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312884&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:336
> -    page.initializeInjectedBundleResourceLoadClient(&client.base);
> +    WKBundlePageSetResourceLoadClient(toAPI(&page), &client.base);

I'm not sure about this change.  From API objects I think we want to call C++ methods, not use the C API.

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:353
> -        _page->initializeInjectedBundleResourceLoadClient(nullptr);
> +        WKBundlePageSetResourceLoadClient(toAPI(_page.get()), nullptr);

ditto

[Carlos Garcia Campos]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 312884 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312884&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:336
> > -    page.initializeInjectedBundleResourceLoadClient(&client.base);
> > +    WKBundlePageSetResourceLoadClient(toAPI(&page), &client.base);
> 
> I'm not sure about this change.  From API objects I think we want to call
> C++ methods, not use the C API.

But the C API is used there, mixing both is what caused this. If you prefer to use the C++ API, then this should be migrated to use API::InjectedBundle::ResourceLoadClient the same way we are doing for all our clients in the GTK+ API.

> > Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:353
> > -        _page->initializeInjectedBundleResourceLoadClient(nullptr);
> > +        WKBundlePageSetResourceLoadClient(toAPI(_page.get()), nullptr);
> 
> ditto

Thanks for all the reviews, btw!

[Carlos Garcia Campos]

Committed r218266: <http://trac.webkit.org/changeset/218266>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 173383

[Carlos Garcia Campos]

Committed r218321: <http://trac.webkit.org/changeset/218321>