Bug 173361 – [Win] DRT should not use disk cache.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Per Arne Vollan]

Like on macOS/iOS, DRT on Windows should only use memory cache.

[Per Arne Vollan]

Created attachment 312883 [details]
Patch

[Darin Adler]

Comment on attachment 312883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312883&action=review

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:1469
> +    RetainPtr<CFURLCacheRef> newCache = adoptCF(CFURLCacheCreate(kCFAllocatorDefault, 1024 * 1024, 0, nullptr));

I suggest using auto here, or just putting this inside the function call.

[Per Arne Vollan]

(In reply to Darin Adler from comment #2)
> Comment on attachment 312883 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312883&action=review
> 
> > Tools/DumpRenderTree/win/DumpRenderTree.cpp:1469
> > +    RetainPtr<CFURLCacheRef> newCache = adoptCF(CFURLCacheCreate(kCFAllocatorDefault, 1024 * 1024, 0, nullptr));
> 
> I suggest using auto here, or just putting this inside the function call.

Thanks for reviewing! I will update the patch before landing.

[Per Arne Vollan]

Committed r218255: <https://trac.webkit.org/changeset/218255/webkit>

[Basuke Suzuki]

Per Arne,
What is the source of this decision? We have an cache implementation in WebKitLegacy and wanna test it. So I am very curious what causes this patch.

[Per Arne Vollan]

(In reply to Basuke Suzuki from comment #5)
> Per Arne,
> What is the source of this decision? We have an cache implementation in
> WebKitLegacy and wanna test it. So I am very curious what causes this patch.

I believe we turned off the disk cache because macOS turned it off. You can probably enable it for WinCairo to test the cache implementation.

[Basuke Suzuki]

(In reply to Per Arne Vollan from comment #6)
> (In reply to Basuke Suzuki from comment #5)
> > Per Arne,
> > What is the source of this decision? We have an cache implementation in
> > WebKitLegacy and wanna test it. So I am very curious what causes this patch.

Can you check AppleWin support disk cache or not? Does CFNetwork itself has disk cache feature? I guess that's why there's no need to test'em explicitly with DRT.


> I believe we turned off the disk cache because macOS turned it off. You can
> probably enable it for WinCairo to test the cache implementation.

Yes, we are thinking about that. The code was old and we don't currently maintain them well, but without test, we can't touch them.