Bug 173357 – Add API::InjectedBundle::Client

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

It will be used by the GTK+ port instead of the C API.

[Carlos Garcia Campos]

Created attachment 312872 [details]
Patch

[Carlos Garcia Campos]

Created attachment 312877 [details]
Patch

[Carlos Garcia Campos]

Committed r218263: <http://trac.webkit.org/changeset/218263>

[Matt Lewis]

These API tests are timing out after this revision on macOS:

WebKit2.AttributedSubstringForProposedRangeWithImage
WebKit2.ContextMenuDownloadHTMLDownloadAttribute
WebKit2.ContextMenuDownloadHTMLDownloadAttributeWithSlashes
WebKit2.DidNotHandleKeyDown
WebKit2.FirstResponderScrollingPosition
WebKit2.ScrollByLineCommands
WebKit2.SpacebarScrolling

[WebKit Commit Bot]

Re-opened since this is blocked by bug 173383

[Carlos Garcia Campos]

(In reply to Matt Lewis from comment #4)
> These API tests are timing out after this revision on macOS:
> 
> WebKit2.AttributedSubstringForProposedRangeWithImage
> WebKit2.ContextMenuDownloadHTMLDownloadAttribute
> WebKit2.ContextMenuDownloadHTMLDownloadAttributeWithSlashes
> WebKit2.DidNotHandleKeyDown
> WebKit2.FirstResponderScrollingPosition
> WebKit2.ScrollByLineCommands
> WebKit2.SpacebarScrolling

So, EWS runs layout tests but not api tests? I'm sorry about these failures, I'll investigate them.

[Carlos Garcia Campos]

(In reply to Carlos Garcia Campos from comment #6)
> (In reply to Matt Lewis from comment #4)
> > These API tests are timing out after this revision on macOS:
> > 
> > WebKit2.AttributedSubstringForProposedRangeWithImage
> > WebKit2.ContextMenuDownloadHTMLDownloadAttribute
> > WebKit2.ContextMenuDownloadHTMLDownloadAttributeWithSlashes
> > WebKit2.DidNotHandleKeyDown
> > WebKit2.FirstResponderScrollingPosition
> > WebKit2.ScrollByLineCommands
> > WebKit2.SpacebarScrolling
> 
> So, EWS runs layout tests but not api tests? I'm sorry about these failures,
> I'll investigate them.

So, those tests are the only ones that use createContextWithInjectedBundle() directly, they are not named tests, which means they don't call WKBundleSetClient(). I've checked the patch and I forgot to initialize the client in InjectedBundle constructor, so it must be it, but I haven't checked it yet. I'll try to test it in a macOS to be sure.

[Carlos Garcia Campos]

Ok, that was indeed the problem. I'll land the fixed patch and keep watching the bots.

$ Tools/Scripts/run-api-tests WebKit2.AttributedSubstringForProposedRangeWithImage WebKit2.ContextMenuDownloadHTMLDownloadAttribute WebKit2.DidNotHandleKeyDown WebKit2.FirstResponderScrollingPosition WebKit2.ScrollByLineCommands WebKit2.SpacebarScrolling
Running build-api-tests
PASS WebKit2.AttributedSubstringForProposedRangeWithImage
PASS WebKit2.ContextMenuDownloadHTMLDownloadAttribute
PASS WebKit2.ContextMenuDownloadHTMLDownloadAttributeWithSlashes
PASS WebKit2.DidNotHandleKeyDown
PASS WebKit2.FirstResponderScrollingPosition
PASS WebKit2.ScrollByLineCommands
PASS WebKit2.SpacebarScrolling

[Carlos Garcia Campos]

Committed r218319: <http://trac.webkit.org/changeset/218319>