Bug 173356 - [GTK] integer expression expected if running Tools/gtk/install-dependencies
Summary: [GTK] integer expression expected if running Tools/gtk/install-dependencies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tomas Popela
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-14 01:59 PDT by Tomas Popela
Modified: 2017-06-14 21:01 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.10 KB, patch)
2017-06-14 02:01 PDT, Tomas Popela
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2017-06-14 01:59:13 PDT
If the Tools/gtk/install-dependencies script is ran on the unsupported platform (anything with yum like CentOS 7, RHEL 7) there is a warning about wrong syntax:

Tools/gtk/install-dependencies: line 40: [: Linux: integer expression expected

as the "eq" operand is expected an integer and not a string comparison.
Comment 1 Tomas Popela 2017-06-14 02:01:27 PDT
Created attachment 312870 [details]
Patch
Comment 2 Michael Catanzaro 2017-06-14 08:34:57 PDT
Comment on attachment 312870 [details]
Patch

I hate bash
Comment 3 Tomas Popela 2017-06-14 21:01:15 PDT
Comment on attachment 312870 [details]
Patch

Clearing flags on attachment: 312870

Committed r218314: <http://trac.webkit.org/changeset/218314>
Comment 4 Tomas Popela 2017-06-14 21:01:20 PDT
All reviewed patches have been landed.  Closing bug.