Bug 173355 – [GTK] Use API::InjectedBundle::EditorClient in WebKitWebEditor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Instead of the C API.

[Carlos Garcia Campos]

Created attachment 312869 [details]
Patch

[Zan Dobersek]

Comment on attachment 312869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312869&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.cpp:85
> +    void didChangeSelection(WebPage&, StringImpl* /*notificationName*/) override

Consider UNUSED_PARAM(notificationName), or just not listing the argument name.

[Carlos Garcia Campos]

Committed r218251: <http://trac.webkit.org/changeset/218251>

[Darin Adler]

Comment on attachment 312869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312869&action=review

>> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.cpp:85
>> +    void didChangeSelection(WebPage&, StringImpl* /*notificationName*/) override
> 
> Consider UNUSED_PARAM(notificationName), or just not listing the argument name.

For what it’s worth, I consider commenting out the name to be better than UNUSED_PARAM. I see UNUSED_PARAM as a necessary evil that we try to avoid, since it doesn’t even work -- it silences the warning, but doesn’t prevent use of the thing it marks as "unused"! But maybe we don’t have consensus on that.

[Michael Catanzaro]

UNUSED_PARAM should be used in cases where the parameter is used in one preprocessor conditional but not another. Otherwise, it's better to either comment out or omit the name.

[Darin Adler]

(In reply to Michael Catanzaro from comment #5)
> UNUSED_PARAM should be used in cases where the parameter is used in one
> preprocessor conditional but not another. Otherwise, it's better to either
> comment out or omit the name.

Yes, I agree with that.