Bug 173327 – Web Inspector: Send context attributes for tracked canvases

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

WebGL canvases are able to provide attributes that effect the functionality of the canvas.  The value of these attributes should be visible in the frontend.

[Devin Rousso]

Created attachment 312802 [details]
[Patch] WIP

[Devin Rousso]

Created attachment 312803 [details]
[Image] After Patch is applied

[Devin Rousso]

Created attachment 313375 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 313375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313375&action=review

> LayoutTests/inspector/canvas/context-attributes-expected.txt:13
> +{"alpha":true,"depth":true,"stencil":false,"antialias":true,"premultipliedAlpha":true,"preserveDrawingBuffer":false,"failIfMajorPerformanceCaveat":false}

We could JSON.stringify(obj, null, 2) to make this easier to read.

> Source/WebInspectorUI/UserInterface/Views/CanvasDetailsSidebarPanel.js:221
> +            const columns = {
> +                name: {title: WebInspector.UIString("Name")},
> +                value: {title: WebInspector.UIString("Value"), width: "30%"},
> +            };
> +            dataGrid = this._attributesDataGridRow.dataGrid = new WebInspector.DataGrid(columns);

Style: Again I think we should inline these as the last param. It looks very awkward like this!

[Devin Rousso]

Created attachment 313453 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 313453 [details]
Patch

Clearing flags on attachment: 313453

Committed r218618: <http://trac.webkit.org/changeset/218618>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.