Bug 173322 - Refactor AbsenceOfSetter to AbsenceOfSetEffects
Summary: Refactor AbsenceOfSetter to AbsenceOfSetEffects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-13 12:49 PDT by Michael Saboff
Modified: 2017-06-13 15:39 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.04 KB, patch)
2017-06-13 15:13 PDT, Michael Saboff
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2017-06-13 12:49:15 PDT
The fix to <https://bugs.webkit.org/show_bug.cgi?id=173321> - "DFG doesn't properly handle a property that is change to read only in a prototype" is to add a check for ReadOnly to the AbsenceOfSetter in PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint().  Talking to Phil Pizlo it makes sense to reflect the changed functionality in the name of AbsenceOfSetter in all of it's uses.
Comment 1 Michael Saboff 2017-06-13 15:10:17 PDT
Settled on AbsenceOfSetEffects.
Comment 2 Michael Saboff 2017-06-13 15:13:57 PDT
Created attachment 312816 [details]
Patch
Comment 3 Filip Pizlo 2017-06-13 15:14:48 PDT
Comment on attachment 312816 [details]
Patch

r=me
Comment 4 Michael Saboff 2017-06-13 15:39:36 PDT
Committed r218218: <http://trac.webkit.org/changeset/218218>