WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
173322
Refactor AbsenceOfSetter to AbsenceOfSetEffects
https://bugs.webkit.org/show_bug.cgi?id=173322
Summary
Refactor AbsenceOfSetter to AbsenceOfSetEffects
Michael Saboff
Reported
2017-06-13 12:49:15 PDT
The fix to <
https://bugs.webkit.org/show_bug.cgi?id=173321
> - "DFG doesn't properly handle a property that is change to read only in a prototype" is to add a check for ReadOnly to the AbsenceOfSetter in PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint(). Talking to Phil Pizlo it makes sense to reflect the changed functionality in the name of AbsenceOfSetter in all of it's uses.
Attachments
Patch
(10.04 KB, patch)
2017-06-13 15:13 PDT
,
Michael Saboff
fpizlo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Saboff
Comment 1
2017-06-13 15:10:17 PDT
Settled on AbsenceOfSetEffects.
Michael Saboff
Comment 2
2017-06-13 15:13:57 PDT
Created
attachment 312816
[details]
Patch
Filip Pizlo
Comment 3
2017-06-13 15:14:48 PDT
Comment on
attachment 312816
[details]
Patch r=me
Michael Saboff
Comment 4
2017-06-13 15:39:36 PDT
Committed
r218218
: <
http://trac.webkit.org/changeset/218218
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug