Bug 173312 - [GTK] Use API::NotificationProvider
Summary: [GTK] Use API::NotificationProvider
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 173309
Blocks:
  Show dependency tree / graph
 
Reported: 2017-06-13 06:15 PDT by Carlos Garcia Campos
Modified: 2017-06-15 01:32 PDT (History)
7 users (show)

See Also:

Attachments
Patch (22.76 KB, patch)
2017-06-13 06:19 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (13.02 KB, patch)
2017-06-13 23:23 PDT, Carlos Garcia Campos 		zan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-06-13 06:15:58 PDT 
Instead of the C API.
Comment 1 Carlos Garcia Campos 2017-06-13 06:19:30 PDT 
Created attachment 312767 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-06-13 23:23:36 PDT 
Created attachment 312864 [details]
Patch

I submitted a patch from a different bug :-P
Comment 3 Build Bot 2017-06-13 23:25:33 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Adrian Perez 2017-06-14 01:24:03 PDT 
Comment on attachment 312864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312864&action=review

Informal r+, but please fix the issue with the header before landing.

> Source/WebKit2/UIProcess/API/gtk/WebKitNotificationProvider.cpp:31
> +#include "APINotificationProvider.h"

The EWS cannot find this header. I think some include directory may be missing from
the compiler command line. It seems to be the same issue as for the patch attached
in bug #173351.
Comment 5 Carlos Garcia Campos 2017-06-14 01:25:45 PDT 
It depends on bug #173309
Comment 6 Carlos Garcia Campos 2017-06-15 01:32:20 PDT 
Committed r218322: <http://trac.webkit.org/changeset/218322>