RESOLVED FIXED 173312
[GTK] Use API::NotificationProvider 
https://bugs.webkit.org/show_bug.cgi?id=173312
Summary [GTK] Use API::NotificationProvider
Carlos Garcia Campos
Reported 2017-06-13 06:15:58 PDT
Instead of the C API.
Attachments
Patch (22.76 KB, patch)
2017-06-13 06:19 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (13.02 KB, patch)
2017-06-13 23:23 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-13 06:19:30 PDT
Created attachment 312767 [details] Patch
Carlos Garcia Campos
Comment 2 2017-06-13 23:23:36 PDT
Created attachment 312864 [details] Patch I submitted a patch from a different bug :-P
Build Bot
Comment 3 2017-06-13 23:25:33 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Adrian Perez
Comment 4 2017-06-14 01:24:03 PDT
Comment on attachment 312864 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312864&action=review Informal r+, but please fix the issue with the header before landing. > Source/WebKit2/UIProcess/API/gtk/WebKitNotificationProvider.cpp:31 > +#include "APINotificationProvider.h" The EWS cannot find this header. I think some include directory may be missing from the compiler command line. It seems to be the same issue as for the patch attached in bug #173351.
Carlos Garcia Campos
Comment 5 2017-06-14 01:25:45 PDT
It depends on bug #173309
Carlos Garcia Campos
Comment 6 2017-06-15 01:32:20 PDT
Committed r218322: <http://trac.webkit.org/changeset/218322>
Note You need to log in before you can comment on or make changes to this bug.