Bug 173301 – REGRESSION(r209495): materiauxlaverdure.com fails to load

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ryosuke Niwa]

materiauxlaverdure.com fails to load on STP and Safari 10.1.x.

WebKit's getPropertyValue serializes the compute style value of '{name: \"flat\"}' as '{name: \"flat\"}'
unlike Chrome and Firefox which serializes it as "{name: \"flat\"}"

Because the website only strips away double quotation marks, this results in the website not loading in Safari.

[Ryosuke Niwa]

<rdar://problem/32624850>

[Simon Fraser (smfr)]

That comes out of the mootools library, so this could affect more sites.

[Chris Dumez]

var content = element.getStyle('content');
if (content) {
    content = content.replace(/^\'/, '');
    content = content.replace(/\'$/, '');
    configs = JSON.decode(content); // This fails.
}

[Ryosuke Niwa]

This regressed in Safari 10.1.

[Ryosuke Niwa]

This is a regression from https://trac.webkit.org/changeset/209495

[Ryosuke Niwa]

Now interesting. The old serialization was wrong but in a way that was compatible with mootools library. We were serializing it as '{name: "flat"}' instead of '{name: \"flat\"}' so eval worked.

[Ryosuke Niwa]

Created attachment 312856 [details]
Fixes the bug

[Build Bot]

Comment on attachment 312856 [details]
Fixes the bug

Attachment 312856 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3927364

New failing tests:
fast/text/font-weight-parse.html
fast/text/font-style-parse.html
fast/text/font-stretch-parse.html
fast/css/getComputedStyle/computed-style-font-family.html
fast/css/serialization-with-double-quotes.html

[Build Bot]

Created attachment 312857 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 312856 [details]
Fixes the bug

Attachment 312856 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3927421

New failing tests:
fast/text/font-weight-parse.html
fast/text/font-style-parse.html
fast/text/font-stretch-parse.html
fast/css/getComputedStyle/computed-style-font-family.html
fast/css/serialization-with-double-quotes.html

[Build Bot]

Created attachment 312858 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 312856 [details]
Fixes the bug

Attachment 312856 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3927436

New failing tests:
fast/text/font-weight-parse.html
fast/text/font-style-parse.html
fast/text/font-stretch-parse.html
fast/css/getComputedStyle/computed-style-font-family.html
fast/css/serialization-with-double-quotes.html

[Build Bot]

Created attachment 312861 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 312856 [details]
Fixes the bug

Attachment 312856 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3927441

New failing tests:
fast/css/serialization-with-double-quotes.html

[Build Bot]

Created attachment 312862 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Ryosuke Niwa]

Created attachment 312929 [details]
Rebaselined the tests

[Antti Koivisto]

Comment on attachment 312929 [details]
Rebaselined the tests

View in context: https://bugs.webkit.org/attachment.cgi?id=312929&action=review

> Source/WebCore/css/CSSMarkup.h:32
> +enum class CSSSerializationQuotationMode { Single, Double };

I can't find any uses for CSSSerializationQuotationMode::Single in this patch. Am I missing something obvious?

[Ryosuke Niwa]

Comment on attachment 312929 [details]
Rebaselined the tests

View in context: https://bugs.webkit.org/attachment.cgi?id=312929&action=review

>> Source/WebCore/css/CSSMarkup.h:32
>> +enum class CSSSerializationQuotationMode { Single, Double };
> 
> I can't find any uses for CSSSerializationQuotationMode::Single in this patch. Am I missing something obvious?

Oops, that's a good point. I iteratively removed each instance of ::Single but we don't seem to have one anymore.

[Ryosuke Niwa]

Created attachment 313173 [details]
Removed superfluous enum

[Ryosuke Niwa]

Comment on attachment 313173 [details]
Removed superfluous enum

Thanks for the review.

[WebKit Commit Bot]

Comment on attachment 313173 [details]
Removed superfluous enum

Rejecting attachment 313173 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 313173, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ayoutTests/imported/w3c/ChangeLog
error: Error building trees

Failed to run "['git', 'commit', '--all', '-F', '-']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

You have both LayoutTests/imported/w3c and LayoutTests/imported/w3c/ChangeLog
You have both LayoutTests/imported/w3c and LayoutTests/imported/w3c/ChangeLog
error: Error building trees

Failed to run "['git', 'commit', '--all', '-F', '-']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/3946389

[Ryosuke Niwa]

Committed r218446: <http://trac.webkit.org/changeset/218446>

[Michael Catanzaro]

Committed r219243: <http://trac.webkit.org/changeset/219243>