Bug 173299 - Include PID in some UIProcess-side release logging that relates to a particular WebProcess
Summary: Include PID in some UIProcess-side release logging that relates to a particul...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-12 19:32 PDT by Chris Dumez
Modified: 2022-03-01 02:37 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.64 KB, patch)
2017-06-12 19:33 PDT, Chris Dumez 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-12 19:32:31 PDT 
Include PID in some UIProcess-side release logging that relates to a particular WebProcess.
Comment 1 Chris Dumez 2017-06-12 19:33:01 PDT 
Created attachment 312742 [details]
Patch
Comment 2 Ryosuke Niwa 2017-06-13 13:55:22 PDT 
Comment on attachment 312742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312742&action=review

> Source/WebKit2/UIProcess/WebProcessProxy.cpp:1217
> +    RELEASE_LOG_ERROR(PerformanceLogging, "%p - WebProcessProxy::didExceedActiveMemoryLimit() Terminating WebProcess with pid %d that has exceeded the active memory limit", this, processIdentifier());

Can we be consist and use (pid: %d)?
Comment 3 Chris Dumez 2017-06-13 13:58:20 PDT 
Committed r218201: <http://trac.webkit.org/changeset/218201>