Bug 173297 – [JSC] Create JSSet constructor that accepts it's size as parameter

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Caio Lima]

...

[Caio Lima]

Created attachment 317538 [details]
Patch

[Saam Barati]

Comment on attachment 317538 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317538&action=review

r=me

> Source/JavaScriptCore/runtime/HashMapImpl.h:303
> +    HashMapImpl(VM& vm, Structure* structure, uint32_t size)

Nit: Lets call this "expectedSize" or "sizeHint" to give a better intention of what it is.

[Saam Barati]

Comment on attachment 317538 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317538&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        This patch is adding a new constructor to JSSet that defines its
> +        initial size. It is important to avoid re-hashing and mutiple

Nit: It doesn't define its initial size. It gives an expected initial size.

[Mark Lam]

Comment on attachment 317538 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317538&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        [JSC] Crate JSSet constructor that accepts it's size as parameter

typo: /Crate/Create/.

[Caio Lima]

Created attachment 317651 [details]
Patch for landing

[Caio Lima]

Created attachment 317669 [details]
Patch for landing

Rebasing with master

[Caio Lima]

Created attachment 317700 [details]
Patch for landing

Fixing ChangeLog

[WebKit Commit Bot]

Comment on attachment 317700 [details]
Patch for landing

Clearing flags on attachment: 317700

Committed r220500: <http://trac.webkit.org/changeset/220500>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33816652>