Bug 173291 - Web Inspector: Console: Message icons overlay source location
Summary: Web Inspector: Console: Message icons overlay source location
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-12 17:06 PDT by Nikita Vasilyev
Modified: 2017-06-13 21:55 PDT (History)
3 users (show)

See Also:

Attachments
[Image] Bug (157.10 KB, image/png)
2017-06-12 17:06 PDT, Nikita Vasilyev 		no flags Details
Patch (1.35 KB, patch)
2017-06-13 18:04 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Image] Before/after (85.89 KB, image/png)
2017-06-13 18:16 PDT, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2017-06-12 17:06:31 PDT 
Created attachment 312734 [details]
[Image] Bug

Source code location should be clipped so it doesn't overlap with console message icons.
Comment 1 Nikita Vasilyev 2017-06-12 17:11:16 PDT 
I wish I could use this:

    .console-message-location.call-frame {
        max-width: min(50vw, 100%);
    }

Something like this may be speced in CSS4 Values: https://github.com/w3c/csswg-drafts/issues/544
Comment 2 Nikita Vasilyev 2017-06-13 18:04:52 PDT 
Created attachment 312839 [details]
Patch
Comment 3 Nikita Vasilyev 2017-06-13 18:16:04 PDT 
Created attachment 312843 [details]
[Image] Before/after
Comment 4 Matt Baker 2017-06-13 21:26:52 PDT 
Comment on attachment 312839 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2017-06-13 21:55:07 PDT 
Comment on attachment 312839 [details]
Patch

Clearing flags on attachment: 312839

Committed r218243: <http://trac.webkit.org/changeset/218243>
Comment 6 WebKit Commit Bot 2017-06-13 21:55:09 PDT 
All reviewed patches have been landed.  Closing bug.