Bug 173280 - [WK2][macOS] Allow AppleEvents for the Citrix Viewer Plugin
Summary: [WK2][macOS] Allow AppleEvents for the Citrix Viewer Plugin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-12 16:10 PDT by Brent Fulgham
Modified: 2022-03-01 02:37 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.32 KB, patch)
2017-06-12 16:17 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (2.26 KB, patch)
2017-06-12 16:44 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2017-06-13 10:27 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (1.72 KB, patch)
2017-06-13 13:36 PDT, Brent Fulgham 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-06-12 16:10:32 PDT 
The plugin process should allow AppleEvents. Since the Plugin Process is generally not sandboxed, this doesn't introduce any new security risks.
Comment 1 Brent Fulgham 2017-06-12 16:11:27 PDT 
<rdar://problem/31913624>
Comment 2 Brent Fulgham 2017-06-12 16:17:15 PDT 
Created attachment 312717 [details]
Patch
Comment 3 Brent Fulgham 2017-06-12 16:41:48 PDT 
Comment on attachment 312717 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312717&action=review

> Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:34
> +#import <wtf/text/WTFString.h>

This line isn't needed.
Comment 4 Brent Fulgham 2017-06-12 16:44:37 PDT 
Created attachment 312728 [details]
Patch
Comment 5 Alexey Proskuryakov 2017-06-12 18:53:16 PDT 
Comment on attachment 312728 [details]
Patch

iOS EWS is red.
Comment 6 Brady Eidson 2017-06-12 19:19:01 PDT 
(In reply to Brent Fulgham from comment #0)
> The plugin process should allow AppleEvents. 

Why.
Comment 7 Brent Fulgham 2017-06-12 21:18:31 PDT 
(In reply to Brady Eidson from comment #6)
> (In reply to Brent Fulgham from comment #0)
> > The plugin process should allow AppleEvents. 
> 
> Why.

See rdar
Comment 8 Brent Fulgham 2017-06-13 10:27:24 PDT 
Created attachment 312785 [details]
Patch
Comment 9 Alexey Proskuryakov 2017-06-13 10:38:30 PDT 
Comment on attachment 312785 [details]
Patch

r=me assuming that this fix was confirmed to work by testing.
Comment 10 WebKit Commit Bot 2017-06-13 11:39:29 PDT 
Comment on attachment 312785 [details]
Patch

Clearing flags on attachment: 312785

Committed r218187: <http://trac.webkit.org/changeset/218187>
Comment 11 WebKit Commit Bot 2017-06-13 11:39:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Brent Fulgham 2017-06-13 13:30:53 PDT 
Reopening to allow AppleEvents for non-sandboxed plugins.
Comment 13 Brent Fulgham 2017-06-13 13:36:51 PDT 
Created attachment 312798 [details]
Patch
Comment 14 Brent Fulgham 2017-06-13 14:58:38 PDT 
Committed r218206: <http://trac.webkit.org/changeset/218206>