Bug 173278 – Screen sleeps while doing WebRTC video

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

Screen sleeps while doing WebRTC video

[Jer Noble]

<rdar://problem/32518760>

[Radar WebKit Bug Importer]

<rdar://problem/32723876>

[Jer Noble]

Created attachment 312710 [details]
Patch

[Jon Lee]

<rdar://problem/32518760>

[Eric Carlson]

Comment on attachment 312710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312710&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:6362
> +    if (m_mediaStreamSrcObject) {
> +        // Do not block system from sleeping if element is only rendering local (capture) sources.
> +        if (WTF::allOf(m_mediaStreamSrcObject->getTracks(), [] (RefPtr<MediaStreamTrack>& track) {
> +            return track && track->isCaptureTrack();
> +        }))
> +            return SleepType::None;
> +    }

Nit: This indentation is confusing, even though it is technically correct. It would be much easier to understand if the allOf was on a single line:

if (WTF::allOf(m_mediaStreamSrcObject->getTracks(), [] (RefPtr<MediaStreamTrack>& track) { return track && track->isCaptureTrack(); }))
    return SleepType::None;

[Jer Noble]

Created attachment 312712 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 312712 [details]
Patch for landing

Clearing flags on attachment: 312712

Committed r218151: <http://trac.webkit.org/changeset/218151>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.