Bug 173269 - Seeking an MSE video will begin playing audio long before rendering video
Summary: Seeking an MSE video will begin playing audio long before rendering video
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-12 13:00 PDT by Jer Noble
Modified: 2017-06-13 14:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.72 KB, patch)
2017-06-12 13:25 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (16.96 KB, patch)
2017-06-12 15:16 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (16.96 KB, patch)
2017-06-12 15:42 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-06-12 13:00:59 PDT 
Seeking an MSE video will begin playing audio long before rendering video
Comment 1 Jer Noble 2017-06-12 13:25:01 PDT 
Created attachment 312688 [details]
Patch
Comment 2 Eric Carlson 2017-06-12 13:43:18 PDT 
Comment on attachment 312688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312688&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:440
> +    if (!CFEqual(kCMSampleBufferConsumerNotification_BufferConsumed, notificationName))

Nit: kCMSampleBufferConsumerNotification_BufferConsumed should be soft linked.

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:983
> +                CMSetAttachment(sampleCopy.get(), kCMSampleBufferAttachmentKey_PostNotificationWhenConsumed, @{kBufferConsumedContext: context.get()}, kCMAttachmentMode_ShouldNotPropagate);

Nit: ditto for kCMSampleBufferAttachmentKey_PostNotificationWhenConsumed.
Comment 3 Jer Noble 2017-06-12 15:16:06 PDT 
Created attachment 312707 [details]
Patch for landing
Comment 4 Jer Noble 2017-06-12 15:17:28 PDT 
<rdar://problem/32448773>
Comment 5 Radar WebKit Bug Importer 2017-06-12 15:17:58 PDT 
<rdar://problem/32723702>
Comment 6 Jon Lee 2017-06-12 15:30:32 PDT 
<rdar://problem/32448773>
Comment 7 Jer Noble 2017-06-12 15:42:48 PDT 
Created attachment 312711 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2017-06-12 15:57:22 PDT 
Comment on attachment 312711 [details]
Patch for landing

Clearing flags on attachment: 312711

Committed r218150: <http://trac.webkit.org/changeset/218150>
Comment 9 WebKit Commit Bot 2017-06-12 15:57:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Matt Lewis 2017-06-12 17:11:06 PDT 
Follow-up build fix:
https://trac.webkit.org/changeset/218158/webkit