Bug 173269 – Seeking an MSE video will begin playing audio long before rendering video

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

Seeking an MSE video will begin playing audio long before rendering video

[Jer Noble]

Created attachment 312688 [details]
Patch

[Eric Carlson]

Comment on attachment 312688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312688&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:440
> +    if (!CFEqual(kCMSampleBufferConsumerNotification_BufferConsumed, notificationName))

Nit: kCMSampleBufferConsumerNotification_BufferConsumed should be soft linked.

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:983
> +                CMSetAttachment(sampleCopy.get(), kCMSampleBufferAttachmentKey_PostNotificationWhenConsumed, @{kBufferConsumedContext: context.get()}, kCMAttachmentMode_ShouldNotPropagate);

Nit: ditto for kCMSampleBufferAttachmentKey_PostNotificationWhenConsumed.

[Jer Noble]

Created attachment 312707 [details]
Patch for landing

[Jer Noble]

<rdar://problem/32448773>

[Radar WebKit Bug Importer]

<rdar://problem/32723702>

[Jon Lee]

<rdar://problem/32448773>

[Jer Noble]

Created attachment 312711 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 312711 [details]
Patch for landing

Clearing flags on attachment: 312711

Committed r218150: <http://trac.webkit.org/changeset/218150>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Matt Lewis]

Follow-up build fix:
https://trac.webkit.org/changeset/218158/webkit