Bug 173267 – Regression(r217867): Legacy SessionHistoryEntryData format should not change

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Legacy SessionHistoryEntryData format should not change, to preserve compatibility.

[Chris Dumez]

<rdar://problem/32701257>

[Chris Dumez]

Created attachment 312678 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 312678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312678&action=review

> Source/WebKit2/ChangeLog:10
> +        as this apparently breaks compatiblity.

Would be nice to explain a little more why.

[Chris Dumez]

Comment on attachment 312678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312678&action=review

>> Source/WebKit2/ChangeLog:10
>> +        as this apparently breaks compatiblity.
> 
> Would be nice to explain a little more why.

I cc'd Sam and Anders to see if they can educate me. What I saw is that the legacy session state encoding / decoding code has quite a few "Encode / decode unused X field here to maintain format compatibility". So clearly, keeping the exact same format is important.
Note that there is versioning but I tried bumping the version number and it did not help.

My assumption is that the client (Safari?) relies on our current format somehow.

[Chris Dumez]

Comment on attachment 312678 [details]
Patch

Clearing flags on attachment: 312678

Committed r218121: <http://trac.webkit.org/changeset/218121>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.