Bug 173267 - Regression(r217867): Legacy SessionHistoryEntryData format should not change
Summary: Regression(r217867): Legacy SessionHistoryEntryData format should not change
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 173033
  Show dependency tree / graph
 
Reported: 2017-06-12 10:51 PDT by Chris Dumez
Modified: 2017-06-12 11:55 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.17 KB, patch)
2017-06-12 10:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-12 10:51:35 PDT 
Legacy SessionHistoryEntryData format should not change, to preserve compatibility.
Comment 1 Chris Dumez 2017-06-12 10:51:51 PDT 
<rdar://problem/32701257>
Comment 2 Chris Dumez 2017-06-12 10:54:35 PDT 
Created attachment 312678 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-06-12 11:24:09 PDT 
Comment on attachment 312678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312678&action=review

> Source/WebKit2/ChangeLog:10
> +        as this apparently breaks compatiblity.

Would be nice to explain a little more why.
Comment 4 Chris Dumez 2017-06-12 11:54:42 PDT 
Comment on attachment 312678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312678&action=review

>> Source/WebKit2/ChangeLog:10
>> +        as this apparently breaks compatiblity.
> 
> Would be nice to explain a little more why.

I cc'd Sam and Anders to see if they can educate me. What I saw is that the legacy session state encoding / decoding code has quite a few "Encode / decode unused X field here to maintain format compatibility". So clearly, keeping the exact same format is important.
Note that there is versioning but I tried bumping the version number and it did not help.

My assumption is that the client (Safari?) relies on our current format somehow.
Comment 5 Chris Dumez 2017-06-12 11:55:36 PDT 
Comment on attachment 312678 [details]
Patch

Clearing flags on attachment: 312678

Committed r218121: <http://trac.webkit.org/changeset/218121>
Comment 6 Chris Dumez 2017-06-12 11:55:38 PDT 
All reviewed patches have been landed.  Closing bug.