RESOLVED FIXED 173265
Add API::InjectedBundle::PageLoaderClient 
https://bugs.webkit.org/show_bug.cgi?id=173265
Summary Add API::InjectedBundle::PageLoaderClient
Carlos Garcia Campos
Reported 2017-06-12 09:27:37 PDT
It will be used by the GTK+ port instead of the C API.
Attachments
Patch (75.34 KB, patch)
2017-06-12 09:30 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (75.35 KB, patch)
2017-06-12 09:37 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (76.72 KB, patch)
2017-06-12 09:46 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (76.73 KB, patch)
2017-06-12 09:52 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (1.56 KB, patch)
2017-06-13 15:28 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-12 09:30:24 PDT
Created attachment 312673 [details] Patch
Carlos Garcia Campos
Comment 2 2017-06-12 09:37:33 PDT
Created attachment 312674 [details] Patch
Carlos Garcia Campos
Comment 3 2017-06-12 09:46:00 PDT
Created attachment 312675 [details] Patch
Carlos Garcia Campos
Comment 4 2017-06-12 09:52:01 PDT
Created attachment 312676 [details] Patch
Alex Christensen
Comment 5 2017-06-12 10:22:41 PDT
Comment on attachment 312676 [details] Patch What does this allow that the existing infrastructure does not? Apple doesn't have any public injected bundle API.
Carlos Garcia Campos
Comment 6 2017-06-12 10:30:21 PDT
(In reply to Alex Christensen from comment #5) > Comment on attachment 312676 [details] > Patch > > What does this allow that the existing infrastructure does not? Apple > doesn't have any public injected bundle API. I think this is "the new way", we have other clients in the injected bundle following this pattern. The main advantage is that we can easily modify the interface, without having to deal with the C API interfaces versions. I'm doing it now, because I want to get rid of the C API usage leftovers in the GTK+ API implementation. This will make easier to refactor the common code to reuse as much as possible for the new glib based api for WPE.
Alex Christensen
Comment 7 2017-06-12 10:36:21 PDT
Comment on attachment 312676 [details] Patch Sure, r=me. It would be nice if WPE could not have injected bundle API. It would also be nice if GTK had no injected bundle API. I want a pony.
Carlos Garcia Campos
Comment 8 2017-06-12 23:28:59 PDT
Committed r218164: <http://trac.webkit.org/changeset/218164>
Chris Dumez
Comment 9 2017-06-13 15:27:49 PDT
Reopen for follow-up fix.
Chris Dumez
Comment 10 2017-06-13 15:28:44 PDT
Created attachment 312819 [details] Patch
Chris Dumez
Comment 11 2017-06-13 15:32:03 PDT
Committed r218217: <http://trac.webkit.org/changeset/218217>
Alex Christensen
Comment 12 2017-06-13 15:32:55 PDT
rdar://problem/32743193
Note You need to log in before you can comment on or make changes to this bug.