Bug 173265 - Add API::InjectedBundle::PageLoaderClient
Summary: Add API::InjectedBundle::PageLoaderClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-12 09:27 PDT by Carlos Garcia Campos
Modified: 2017-06-13 15:32 PDT (History)
6 users (show)

See Also:


Attachments
Patch (75.34 KB, patch)
2017-06-12 09:30 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch (75.35 KB, patch)
2017-06-12 09:37 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch (76.72 KB, patch)
2017-06-12 09:46 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch (76.73 KB, patch)
2017-06-12 09:52 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch (1.56 KB, patch)
2017-06-13 15:28 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-06-12 09:27:37 PDT
It will be used by the GTK+ port instead of the C API.
Comment 1 Carlos Garcia Campos 2017-06-12 09:30:24 PDT
Created attachment 312673 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-06-12 09:37:33 PDT
Created attachment 312674 [details]
Patch
Comment 3 Carlos Garcia Campos 2017-06-12 09:46:00 PDT
Created attachment 312675 [details]
Patch
Comment 4 Carlos Garcia Campos 2017-06-12 09:52:01 PDT
Created attachment 312676 [details]
Patch
Comment 5 Alex Christensen 2017-06-12 10:22:41 PDT
Comment on attachment 312676 [details]
Patch

What does this allow that the existing infrastructure does not?  Apple doesn't have any public injected bundle API.
Comment 6 Carlos Garcia Campos 2017-06-12 10:30:21 PDT
(In reply to Alex Christensen from comment #5)
> Comment on attachment 312676 [details]
> Patch
> 
> What does this allow that the existing infrastructure does not?  Apple
> doesn't have any public injected bundle API.

I think this is "the new way", we have other clients in the injected bundle following this pattern. The main advantage is that we can easily modify the interface, without having to deal with the C API interfaces versions. I'm doing it now, because I want to get rid of the C API usage leftovers in the GTK+ API implementation. This will make easier to refactor the common code to reuse as much as possible for the new glib based api for WPE.
Comment 7 Alex Christensen 2017-06-12 10:36:21 PDT
Comment on attachment 312676 [details]
Patch

Sure, r=me.
It would be nice if WPE could not have injected bundle API.  It would also be nice if GTK had no injected bundle API.  I want a pony.
Comment 8 Carlos Garcia Campos 2017-06-12 23:28:59 PDT
Committed r218164: <http://trac.webkit.org/changeset/218164>
Comment 9 Chris Dumez 2017-06-13 15:27:49 PDT
Reopen for follow-up fix.
Comment 10 Chris Dumez 2017-06-13 15:28:44 PDT
Created attachment 312819 [details]
Patch
Comment 11 Chris Dumez 2017-06-13 15:32:03 PDT
Committed r218217: <http://trac.webkit.org/changeset/218217>
Comment 12 Alex Christensen 2017-06-13 15:32:55 PDT
rdar://problem/32743193