Bug 173264 - Call _sqlite3_purgeEligiblePagerCacheMemory() on memory pressure only if sqlite is initialized
Summary: Call _sqlite3_purgeEligiblePagerCacheMemory() on memory pressure only if sqli...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-12 09:21 PDT by Chris Dumez
Modified: 2017-06-13 09:21 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.93 KB, patch)
2017-06-12 09:28 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-12 09:21:41 PDT 
Call _sqlite3_purgeEligiblePagerCacheMemory() on memory pressure only if sqlite is initialized.
Comment 1 Chris Dumez 2017-06-12 09:28:52 PDT 
Created attachment 312672 [details]
Patch
Comment 2 Chris Dumez 2017-06-12 09:29:13 PDT 
<rdar://problem/30780050>
Comment 3 Ryosuke Niwa 2017-06-12 10:13:57 PDT 
Comment on attachment 312672 [details]
Patch

Okay. Let's try this fix.
Comment 4 Chris Dumez 2017-06-12 10:28:44 PDT 
Comment on attachment 312672 [details]
Patch

Clearing flags on attachment: 312672

Committed r218108: <http://trac.webkit.org/changeset/218108>
Comment 5 Chris Dumez 2017-06-12 10:28:46 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2017-06-13 09:02:09 PDT 
Comment on attachment 312672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312672&action=review

> Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm:43
> +static bool isSQLiteMemoryPressureHandlerRegisted { false };

Typo here: "registed" instead of "registered".
Comment 7 Chris Dumez 2017-06-13 09:21:37 PDT 
(In reply to Darin Adler from comment #6)
> Comment on attachment 312672 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312672&action=review
> 
> > Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm:43
> > +static bool isSQLiteMemoryPressureHandlerRegisted { false };
> 
> Typo here: "registed" instead of "registered".

Thanks, I have fixed the typo in <http://trac.webkit.org/changeset/218178>.