WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
173264
Call _sqlite3_purgeEligiblePagerCacheMemory() on memory pressure only if sqlite is initialized
https://bugs.webkit.org/show_bug.cgi?id=173264
Summary
Call _sqlite3_purgeEligiblePagerCacheMemory() on memory pressure only if sqli...
Chris Dumez
Reported
2017-06-12 09:21:41 PDT
Call _sqlite3_purgeEligiblePagerCacheMemory() on memory pressure only if sqlite is initialized.
Attachments
Patch
(3.93 KB, patch)
2017-06-12 09:28 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2017-06-12 09:28:52 PDT
Created
attachment 312672
[details]
Patch
Chris Dumez
Comment 2
2017-06-12 09:29:13 PDT
<
rdar://problem/30780050
>
Ryosuke Niwa
Comment 3
2017-06-12 10:13:57 PDT
Comment on
attachment 312672
[details]
Patch Okay. Let's try this fix.
Chris Dumez
Comment 4
2017-06-12 10:28:44 PDT
Comment on
attachment 312672
[details]
Patch Clearing flags on attachment: 312672 Committed
r218108
: <
http://trac.webkit.org/changeset/218108
>
Chris Dumez
Comment 5
2017-06-12 10:28:46 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 6
2017-06-13 09:02:09 PDT
Comment on
attachment 312672
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=312672&action=review
> Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm:43 > +static bool isSQLiteMemoryPressureHandlerRegisted { false };
Typo here: "registed" instead of "registered".
Chris Dumez
Comment 7
2017-06-13 09:21:37 PDT
(In reply to Darin Adler from
comment #6
)
> Comment on
attachment 312672
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=312672&action=review
> > > Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm:43 > > +static bool isSQLiteMemoryPressureHandlerRegisted { false }; > > Typo here: "registed" instead of "registered".
Thanks, I have fixed the typo in <
http://trac.webkit.org/changeset/218178
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug