Bug 173254 - [GTK] Prefer to use private WebKitWebView API over WebKitWebViewBase
Summary: [GTK] Prefer to use private WebKitWebView API over WebKitWebViewBase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 173251
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-12 03:28 PDT by Carlos Garcia Campos
Modified: 2017-06-12 05:59 PDT (History)
6 users (show)

See Also:


Attachments
Patch (19.98 KB, patch)
2017-06-12 03:31 PDT, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-06-12 03:28:10 PDT
WebKitWebViewBase is specific to the GTK+ API, but WebKitWebView should be present in any glib-based API.
Comment 1 Carlos Garcia Campos 2017-06-12 03:31:14 PDT
Created attachment 312649 [details]
Patch
Comment 2 Build Bot 2017-06-12 03:32:03 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2017-06-12 05:59:01 PDT
Committed r218098: <http://trac.webkit.org/changeset/218098>