RESOLVED CONFIGURATION CHANGED 17325
Remove PLATFORM ifdefs from HTMLFormElement 
https://bugs.webkit.org/show_bug.cgi?id=17325
Summary Remove PLATFORM ifdefs from HTMLFormElement
Eric Seidel (no email)
Reported 2008-02-12 01:33:48 PST
Remove PLATFORM ifdefs from HTMLFormElement html/HTMLFormElement.cpp:45:#if PLATFORM(QT) html/HTMLFormElement.cpp:49:#if PLATFORM(WX) html/HTMLFormElement.cpp:54:#if PLATFORM(WIN_OS) html/HTMLFormElement.cpp:210:#if PLATFORM(DARWIN) html/HTMLFormElement.cpp:230:#if PLATFORM(QT) html/HTMLFormElement.cpp:232:#elif PLATFORM(WX) html/HTMLFormElement.cpp:234:#elif PLATFORM(WIN_OS) There is no reason why we need these there. We need a random number platform abstraction and a way to do filename operations. Both belong in platform/ not in HTMLFormElement.cpp
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2022-07-25 16:40:49 PDT
I can't find keyword "Platform" in Webkit Github repo as of today: https://github.com/WebKit/WebKit/blob/c68178ddc01939b4bce3cdb9718c62087649dad4/Source/WebCore/html/HTMLFormElement.cpp https://github.com/WebKit/WebKit/blob/e4e4bba1f291d4773b907199bb5e6976d14c223d/Source/WebCore/html/HTMLFormElement.h I think this can be marked as "RESOLVED CONFIGURATION CHANGED". Thanks!
Note You need to log in before you can comment on or make changes to this bug.