Bug 173249 – [GTK] Move WebKit GType macros to WTF

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Moving to a shared place where they could be shared by all ports using a glib-based API. Moved to WTF instead of platform/PAL because they will also be used by JavaScriptCore glib bindings.

[Carlos Garcia Campos]

Created attachment 312642 [details]
Patch

[Build Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Build Bot]

Attachment 312642 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/glib/WebKitGType.h:74:  g_define_type_id__volatile is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/glib/WebKitGType.h:76:  g_define_type_id is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zan Dobersek]

Comment on attachment 312642 [details]
Patch

It looks OK. WEBKIT prefixes seem a bit strange for code that's located in WTF though.

[Carlos Garcia Campos]

(In reply to Zan Dobersek from comment #4)
> Comment on attachment 312642 [details]
> Patch
> 
> It looks OK. WEBKIT prefixes seem a bit strange for code that's located in
> WTF though.

Yes, they are currently helpers for glib based APIs that use WebKit prefix. They can be renamed to use WTF prefix once the JSC glib bindings are added, since we will not use WebKit prefix there.

[Carlos Garcia Campos]

Committed r218096: <http://trac.webkit.org/changeset/218096>