Bug 173245 – [Mac] Unaligned pointers in static CMBufferCallbacks structs defined in WebCoreDecompressionSession.mm

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

When building WebCore with the Xcode 9 public beta, the linker warns that pointers in the CMBufferCallbacks structs defined in WebCoreDecompressionSession are not 8-byte aligned.

Created attachment 312625 [details]
Align the structs

(In reply to mitz from comment #0)
> Xcode 9 public beta

Mean to say developer beta.

[Build Bot]

Attachment 312625 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:137:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:158:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 312625 [details]
Align the structs

Can we use alignas instead?

(In reply to Sam Weinig from comment #4)
> Comment on attachment 312625 [details]
> Align the structs
> 
> Can we use alignas instead?

How?

[Sam Weinig]

I played around and couldn't figure out a way to use it that wasn't more verbose than this.

[WebKit Commit Bot]

Comment on attachment 312625 [details]
Align the structs

Clearing flags on attachment: 312625

Committed r218081: <http://trac.webkit.org/changeset/218081>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.