Bug 173238 – [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Wenson Hsieh]

<rdar://problem/31943370>

[Wenson Hsieh]

Created attachment 312600 [details]
Patch

[Wenson Hsieh]

Created attachment 312604 [details]
Fix GTK build

[Ryosuke Niwa]

Comment on attachment 312604 [details]
Fix GTK build

View in context: https://bugs.webkit.org/attachment.cgi?id=312604&action=review

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1431
> +    encoder << types;

We should assert that the size of data & types are the same.

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1433
> +    for (size_t i = 0; i < data.size(); i++)

Why don't we save the size like you did in PlatformPasteboardIOS.mm?

[Wenson Hsieh]

Comment on attachment 312604 [details]
Fix GTK build

View in context: https://bugs.webkit.org/attachment.cgi?id=312604&action=review

Thanks Ryosuke! I think we'll still need a WK2 reviewer to rubberstamp this though, since it touches WebKit2.

>> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1431
>> +    encoder << types;
> 
> We should assert that the size of data & types are the same.

Good idea -- added an assert.

>> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1433
>> +    for (size_t i = 0; i < data.size(); i++)
> 
> Why don't we save the size like you did in PlatformPasteboardIOS.mm?

Done!

[Tim Horton]

Comment on attachment 312604 [details]
Fix GTK build

wk2r=me

[Wenson Hsieh]

Created attachment 312684 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 312684 [details]
Patch for landing

Clearing flags on attachment: 312684

Committed r218128: <http://trac.webkit.org/changeset/218128>