Bug 173231 - Remove WebCore::unloadModule and related data types.
Summary: Remove WebCore::unloadModule and related data types.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daewoong Jang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-10 17:22 PDT by Daewoong Jang
Modified: 2017-06-12 18:28 PDT (History)
6 users (show)

See Also:

Attachments
patch (8.27 KB, patch)
2017-06-10 17:26 PDT, Daewoong Jang 		no flags Details | Formatted Diff | Diff
patch (8.14 KB, patch)
2017-06-10 17:35 PDT, Daewoong Jang 		darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
rebased patch (8.11 KB, patch)
2017-06-12 16:32 PDT, Daewoong Jang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daewoong Jang 2017-06-10 17:22:44 PDT 
Remove WebCore::unloadModule and related data types such as PlatformModule and PlatformModuleVersion since they are not used outside WebKit/win/Plugins.
Comment 1 Daewoong Jang 2017-06-10 17:26:06 PDT 
Created attachment 312584 [details]
patch
Comment 2 Build Bot 2017-06-10 17:28:42 PDT 
Attachment 312584 [details] did not pass style-queue:


ERROR: Source/WebKit/win/Plugins/PlatformModule.h:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/WebKit/win/Plugins/PlatformModule.h:31:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 59 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Daewoong Jang 2017-06-10 17:35:08 PDT 
Created attachment 312585 [details]
patch
Comment 4 WebKit Commit Bot 2017-06-12 12:50:46 PDT 
Comment on attachment 312585 [details]
patch

Rejecting attachment 312585 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 312585, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
.webkit.org/git/WebKit
   b90d219..833b332  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 218124 = b90d21939d2d5b208d4f93a6216c4e6da6371e12
r218125 = 833b332e555b3a26b082e77c3d3ff6002970c885
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/3918795
Comment 5 Daewoong Jang 2017-06-12 16:32:56 PDT 
Created attachment 312723 [details]
rebased patch
Comment 6 WebKit Commit Bot 2017-06-12 18:28:41 PDT 
Comment on attachment 312723 [details]
rebased patch

Clearing flags on attachment: 312723

Committed r218160: <http://trac.webkit.org/changeset/218160>
Comment 7 WebKit Commit Bot 2017-06-12 18:28:43 PDT 
All reviewed patches have been landed.  Closing bug.