Bug 173225 - [iOS DnD] WebItemProviderPasteboard should call its completion block immediately after a synchronous load
Summary: [iOS DnD] WebItemProviderPasteboard should call its completion block immediat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-10 03:49 PDT by Wenson Hsieh
Modified: 2017-06-12 12:34 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.39 KB, patch)
2017-06-10 03:59 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Add rdar link to ChangeLogs (7.46 KB, patch)
2017-06-12 08:57 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-06-10 03:49:23 PDT 
If WebItemProviderPasteboard finishes synchronous loading via -doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout:, it should immediately invoke its completion block instead of waiting until the next runloop. This adjusts for current changes on ToT UIKit that break text drop animations; since previewForLiftingItem: will soon be invoked immediately after performDrop:, we will need to call the item provider load completion block within the same runloop as the rest of the performDrop flow, otherwise the preview will be requested before text indicator data is available.
Comment 1 Wenson Hsieh 2017-06-10 03:59:20 PDT 
Created attachment 312569 [details]
Patch
Comment 2 Wenson Hsieh 2017-06-12 08:36:46 PDT 
<rdar://problem/32713144>
Comment 3 Wenson Hsieh 2017-06-12 08:57:26 PDT 
Created attachment 312668 [details]
Add rdar link to ChangeLogs
Comment 4 WebKit Commit Bot 2017-06-12 12:34:40 PDT 
Comment on attachment 312668 [details]
Add rdar link to ChangeLogs

Clearing flags on attachment: 312668

Committed r218125: <http://trac.webkit.org/changeset/218125>
Comment 5 WebKit Commit Bot 2017-06-12 12:34:42 PDT 
All reviewed patches have been landed.  Closing bug.