Bug 173198 - Use WTF::Function instead of std::function in indexeddb code
Summary: Use WTF::Function instead of std::function in indexeddb code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-09 18:31 PDT by Chris Dumez
Modified: 2017-06-09 22:24 PDT (History)
8 users (show)

See Also:

Attachments
Patch (26.71 KB, patch)
2017-06-09 18:32 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (26.73 KB, patch)
2017-06-09 20:23 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (28.77 KB, patch)
2017-06-09 21:45 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-09 18:31:59 PDT 
Use WTF::Function instead of std::function in indexeddb code to avoid copying.
Comment 1 Chris Dumez 2017-06-09 18:32:52 PDT 
Created attachment 312526 [details]
Patch
Comment 2 Build Bot 2017-06-09 18:34:30 PDT 
Attachment 312526 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.h:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:98:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:126:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:127:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.cpp:426:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.h:139:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.h:147:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBFactory.cpp:137:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp:487:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:105:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:106:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:139:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBFactory.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:539:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:561:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 15 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2017-06-09 18:56:25 PDT 
The Mac linking errors do not make sense. I think Mac-EWS bots are in a bad state.
Comment 4 Chris Dumez 2017-06-09 20:23:54 PDT 
Created attachment 312555 [details]
Patch
Comment 5 Build Bot 2017-06-09 20:25:41 PDT 
Attachment 312555 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.h:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:98:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:126:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:127:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.cpp:426:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.h:139:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.h:147:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBFactory.cpp:137:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp:487:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:105:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:106:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:139:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBFactory.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:539:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:561:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 15 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Chris Dumez 2017-06-09 21:45:06 PDT 
Created attachment 312559 [details]
Patch
Comment 7 Build Bot 2017-06-09 21:47:16 PDT 
Attachment 312559 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.h:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:99:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:127:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:128:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.cpp:426:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.h:140:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.h:148:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBFactory.cpp:137:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp:487:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:105:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:106:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:139:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBFactory.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBFactory.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:539:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:561:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 16 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Commit Bot 2017-06-09 22:24:43 PDT 
Comment on attachment 312559 [details]
Patch

Clearing flags on attachment: 312559

Committed r218048: <http://trac.webkit.org/changeset/218048>
Comment 9 WebKit Commit Bot 2017-06-09 22:24:44 PDT 
All reviewed patches have been landed.  Closing bug.