Curl implementation uses adhoc loader client to load resource synchronously, but there's no reason not using SynchronousLoaderClient as other port do.
Created attachment 312681 [details]
Attachment 312681 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/network/curl/SynchronousLoaderClientCurl.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] 
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 312681 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=312681&action=review
Seems like a step in the right direction to match other ports. Could you use Tools/Scripts/prepare-ChangeLog to add a ChangeLog entry?
> + SynchronousLoaderClient client;
> + RefPtr<ResourceHandle> handle = adoptRef(new ResourceHandle(context, request, &client, false, false));
> + if (!handle)
> + return;
null check isn't needed after new in WebKit. In fact, you could do Ref<ResourceHandle> handle = adoptRef(*new ResourceHandle(...))
Yeah, I'm working on it. Still figuring out which tool is right for what I want to.
Created attachment 312685 [details]
Comment on attachment 312685 [details]
Clearing flags on attachment: 312685
Committed r218142: <http://trac.webkit.org/changeset/218142>
All reviewed patches have been landed. Closing bug.