Bug 173195 – [Curl] Use SynchronousLoaderClient for platformLoadResourceSynchronously

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Basuke Suzuki]

Curl implementation uses adhoc loader client to load resource synchronously, but there's no reason not using SynchronousLoaderClient as other port do.

[Basuke Suzuki]

Created attachment 312681 [details]
Patch

[Build Bot]

Attachment 312681 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/curl/SynchronousLoaderClientCurl.cpp:30:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 312681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312681&action=review

Seems like a step in the right direction to match other ports.  Could you use Tools/Scripts/prepare-ChangeLog to add a ChangeLog entry?

> Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:130
> +    SynchronousLoaderClient client;
> +    RefPtr<ResourceHandle> handle = adoptRef(new ResourceHandle(context, request, &client, false, false));
> +    if (!handle)
> +        return;

null check isn't needed after new in WebKit.  In fact, you could do Ref<ResourceHandle> handle = adoptRef(*new ResourceHandle(...))

[Basuke Suzuki]

Yeah, I'm working on it. Still figuring out which tool is right for what I want to.

[Basuke Suzuki]

Created attachment 312685 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 312685 [details]
Patch

Clearing flags on attachment: 312685

Committed r218142: <http://trac.webkit.org/changeset/218142>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.