173182 – Use WTF::Function instead of std::function in NetworkProcess code

Bug 173182 - Use WTF::Function instead of std::function in NetworkProcess code

Summary: Use WTF::Function instead of std::function in NetworkProcess code

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebKit2 (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Chris Dumez

URL:
Keywords:

Depends on:
Blocks:

Reported:	2017-06-09 14:35 PDT by Chris Dumez
Modified:	2017-06-09 15:38 PDT (History)
CC List:	6 users (show)

See Also:

Attachments
Patch (19.16 KB, patch) 2017-06-09 14:36 PDT, Chris Dumez	no flags	Details \| Formatted Diff \| Diff
Patch (19.17 KB, patch) 2017-06-09 14:43 PDT, Chris Dumez	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Chris Dumez 2017-06-09 14:35:30 PDT

Use WTF::Function instead of std::function in NetworkProcess code to avoid unnecessary copying.

Comment 1 Chris Dumez 2017-06-09 14:36:40 PDT

Created attachment 312490 [details]
Patch

Comment 2 Build Bot 2017-06-09 14:39:15 PDT

Attachment 312490 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.h:173:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:96:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:156:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:182:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:228:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:259:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:159:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm:171:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm:186:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 14 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Chris Dumez 2017-06-09 14:43:07 PDT

Created attachment 312491 [details]
Patch

Comment 4 Build Bot 2017-06-09 14:46:26 PDT

Attachment 312491 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.h:173:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:96:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:156:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:182:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:228:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:259:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:159:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm:171:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm:186:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 14 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Chris Dumez 2017-06-09 15:38:45 PDT

Comment on attachment 312491 [details]
Patch

Clearing flags on attachment: 312491

Committed r218024: <http://trac.webkit.org/changeset/218024>

Comment 6 Chris Dumez 2017-06-09 15:38:47 PDT

All reviewed patches have been landed.  Closing bug.