Bug 173181 – TypedArray constructor with string shouldn't throw

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[JF Bastien]

Uint8Array("hi!") throws, it should instead do this:
https://tc39.github.io/ecma262/#sec-typedarray-length

IIUC it just coerces "hi!" to 0 and goes on its merry way. That's what Chrome does, whereas SM says `typein:1:2 TypeError: invalid arguments`.

[Keith Miller]

Created attachment 312629 [details]
Patch

[Build Bot]

Comment on attachment 312629 [details]
Patch

Attachment 312629 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3914441

New failing tests:
fast/canvas/webgl/array-unit-tests.html
webgl/1.0.2/conformance/typedarrays/array-unit-tests.html
fast/canvas/webgl/webgl-array-invalid-ranges.html

[Build Bot]

Created attachment 312630 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[JF Bastien]

Comment on attachment 312629 [details]
Patch

Can you also add a test with an object that has toValue, both returning ont and throwing?

[Build Bot]

Comment on attachment 312629 [details]
Patch

Attachment 312629 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3914446

New failing tests:
fast/canvas/webgl/array-unit-tests.html
webgl/1.0.2/conformance/typedarrays/array-unit-tests.html
fast/canvas/webgl/webgl-array-invalid-ranges.html

[Build Bot]

Created attachment 312631 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 312629 [details]
Patch

Attachment 312629 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3914453

New failing tests:
fast/canvas/webgl/array-unit-tests.html
webgl/1.0.2/conformance/typedarrays/array-unit-tests.html
fast/canvas/webgl/webgl-array-invalid-ranges.html

[Build Bot]

Created attachment 312632 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Keith Miller]

Created attachment 312633 [details]
Patch for landing

[Keith Miller]

Created attachment 312634 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 312634 [details]
Patch for landing

Clearing flags on attachment: 312634

Committed r218082: <http://trac.webkit.org/changeset/218082>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.