RESOLVED FIXED 173176
[DFG] More ArrayIndexOf fixups for various types 
https://bugs.webkit.org/show_bug.cgi?id=173176
Summary [DFG] More ArrayIndexOf fixups for various types
Yusuke Suzuki
Reported 2017-06-09 11:43:19 PDT
...
Attachments
Patch (30.59 KB, patch)
2017-06-13 07:53 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-06-09 12:02:26 PDT
We can make indexOf(null/undefined) etc. faster. (it may be shown in user code because null is typically used as a sentinel). We'll do this in this patch too.
Yusuke Suzuki
Comment 2 2017-06-13 07:53:43 PDT
Created attachment 312770 [details] Patch
Saam Barati
Comment 3 2017-06-19 18:55:52 PDT
Comment on attachment 312770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312770&action=review r=me > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:3066 > + return; not needed > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:3073 > + return; ditto
Yusuke Suzuki
Comment 4 2017-06-19 19:15:41 PDT
Comment on attachment 312770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312770&action=review Thank you! >> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:3066 >> + return; > > not needed Thanks, dropped. >> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:3073 >> + return; > > ditto Fixed.
Yusuke Suzuki
Comment 5 2017-06-19 19:46:13 PDT
Committed r218525: <http://trac.webkit.org/changeset/218525>
Note You need to log in before you can comment on or make changes to this bug.