Bug 173168 - Avoid some ref counting churn in WebResourceLoadStatisticsStore
Summary: Avoid some ref counting churn in WebResourceLoadStatisticsStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 173172
  Show dependency tree / graph
 
Reported: 2017-06-09 10:41 PDT by Chris Dumez
Modified: 2017-06-09 11:47 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.75 KB, patch)
2017-06-09 10:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.76 KB, patch)
2017-06-09 10:52 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.44 KB, patch)
2017-06-09 10:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.41 KB, patch)
2017-06-09 11:08 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-09 10:41:00 PDT 
Avoid some ref counting churn in WebResourceLoadStatisticsStore.
Comment 1 Chris Dumez 2017-06-09 10:43:20 PDT 
Created attachment 312455 [details]
Patch
Comment 2 Chris Dumez 2017-06-09 10:52:30 PDT 
Created attachment 312456 [details]
Patch
Comment 3 Chris Dumez 2017-06-09 10:58:17 PDT 
Created attachment 312457 [details]
Patch
Comment 4 Chris Dumez 2017-06-09 11:08:51 PDT 
Created attachment 312460 [details]
Patch
Comment 5 Chris Dumez 2017-06-09 11:09:24 PDT 
Comment on attachment 312460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312460&action=review

> Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:122
> +        WebProcessProxy::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores(dataTypesToRemove, WTFMove(prevalentResourceDomains), notifyPages, [this, protectedThis = WTFMove(protectedThis)](Vector<String> domainsWithDeletedWebsiteData) mutable {

This was failing to protect |this|.
Comment 6 Brent Fulgham 2017-06-09 11:13:44 PDT 
Comment on attachment 312460 [details]
Patch

r=me
Comment 7 Chris Dumez 2017-06-09 11:32:12 PDT 
Comment on attachment 312460 [details]
Patch

Clearing flags on attachment: 312460

Committed r218002: <http://trac.webkit.org/changeset/218002>
Comment 8 Chris Dumez 2017-06-09 11:32:14 PDT 
All reviewed patches have been landed.  Closing bug.