Bug 173151 - [GTK] Use API::GeolocationProvider in WebKitGeolocationProvider
Summary: [GTK] Use API::GeolocationProvider in WebKitGeolocationProvider
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on: 173150
  Show dependency treegraph
Reported: 2017-06-09 04:25 PDT by Carlos Garcia Campos
Modified: 2017-06-13 03:35 PDT (History)
6 users (show)

See Also:

Patch (7.37 KB, patch)
2017-06-09 04:27 PDT, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-06-09 04:25:05 PDT
Instead of the C API.
Comment 1 Carlos Garcia Campos 2017-06-09 04:27:51 PDT
Created attachment 312425 [details]
Comment 2 Build Bot 2017-06-09 04:30:20 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Zan Dobersek 2017-06-13 03:23:33 PDT
Comment on attachment 312425 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=312425&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.cpp:35

These normally go after the "config.h" and main header inclusion.

> Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.cpp:95
> +} // namespace WebKit
> +

Here the curly brace closing the namespace is inside the ENABLE(GEOLOCATION) guard, while the initial namespace statement is outside it.
Comment 4 Carlos Garcia Campos 2017-06-13 03:35:06 PDT
Committed r218173: <http://trac.webkit.org/changeset/218173>