RESOLVED FIXED 173151
[GTK] Use API::GeolocationProvider in WebKitGeolocationProvider 
https://bugs.webkit.org/show_bug.cgi?id=173151
Summary [GTK] Use API::GeolocationProvider in WebKitGeolocationProvider
Carlos Garcia Campos
Reported 2017-06-09 04:25:05 PDT
Instead of the C API.
Attachments
Patch (7.37 KB, patch)
2017-06-09 04:27 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-09 04:27:51 PDT
Created attachment 312425 [details] Patch
Build Bot
Comment 2 2017-06-09 04:30:20 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Zan Dobersek
Comment 3 2017-06-13 03:23:33 PDT
Comment on attachment 312425 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312425&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.cpp:35 > #if ENABLE(GEOLOCATION) These normally go after the "config.h" and main header inclusion. > Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.cpp:95 > +} // namespace WebKit > + > #endif // ENABLE(GEOLOCATION) Here the curly brace closing the namespace is inside the ENABLE(GEOLOCATION) guard, while the initial namespace statement is outside it.
Carlos Garcia Campos
Comment 4 2017-06-13 03:35:06 PDT
Committed r218173: <http://trac.webkit.org/changeset/218173>
Note You need to log in before you can comment on or make changes to this bug.