Bug 173140 - [GTK] Remove WKFullScreenClientGtk
Summary: [GTK] Remove WKFullScreenClientGtk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2017-06-09 01:08 PDT by Carlos Garcia Campos
Modified: 2017-06-10 23:30 PDT (History)
3 users (show)

See Also:

Attachments
Patch (23.63 KB, patch)
2017-06-09 01:12 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-06-09 01:08:51 PDT 
It's only used internally in the GTK+ API and only making things more complicated.
Comment 1 Carlos Garcia Campos 2017-06-09 01:12:19 PDT 
Created attachment 312407 [details]
Patch
Comment 2 Michael Catanzaro 2017-06-09 07:29:48 PDT 
Comment on attachment 312407 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312407&action=review

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:311
> +    if (WEBKIT_IS_WEB_VIEW(m_viewWidget))
> +        webkitWebViewEnterFullScreen(WEBKIT_WEB_VIEW(m_viewWidget));
> +    else
> +        webkitWebViewBaseEnterFullScreen(WEBKIT_WEB_VIEW_BASE(m_viewWidget));

What... what could be a WebKitWebViewBase but not a WebKitWebView...?
Comment 3 Carlos Garcia Campos 2017-06-10 01:21:33 PDT 
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 312407 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312407&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:311
> > +    if (WEBKIT_IS_WEB_VIEW(m_viewWidget))
> > +        webkitWebViewEnterFullScreen(WEBKIT_WEB_VIEW(m_viewWidget));
> > +    else
> > +        webkitWebViewBaseEnterFullScreen(WEBKIT_WEB_VIEW_BASE(m_viewWidget));
> 
> What... what could be a WebKitWebViewBase but not a WebKitWebView...?

C API WKView, that's why we have WebKitWebViewBase. It's used by WTR and C API unit tests.
Comment 4 Carlos Garcia Campos 2017-06-10 23:30:23 PDT 
Committed r218064: <http://trac.webkit.org/changeset/218064>