RESOLVED FIXED 173140
[GTK] Remove WKFullScreenClientGtk 
https://bugs.webkit.org/show_bug.cgi?id=173140
Summary [GTK] Remove WKFullScreenClientGtk
Carlos Garcia Campos
Reported 2017-06-09 01:08:51 PDT
It's only used internally in the GTK+ API and only making things more complicated.
Attachments
Patch (23.63 KB, patch)
2017-06-09 01:12 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-09 01:12:19 PDT
Created attachment 312407 [details] Patch
Michael Catanzaro
Comment 2 2017-06-09 07:29:48 PDT
Comment on attachment 312407 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312407&action=review > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:311 > + if (WEBKIT_IS_WEB_VIEW(m_viewWidget)) > + webkitWebViewEnterFullScreen(WEBKIT_WEB_VIEW(m_viewWidget)); > + else > + webkitWebViewBaseEnterFullScreen(WEBKIT_WEB_VIEW_BASE(m_viewWidget)); What... what could be a WebKitWebViewBase but not a WebKitWebView...?
Carlos Garcia Campos
Comment 3 2017-06-10 01:21:33 PDT
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 312407 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312407&action=review > > > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:311 > > + if (WEBKIT_IS_WEB_VIEW(m_viewWidget)) > > + webkitWebViewEnterFullScreen(WEBKIT_WEB_VIEW(m_viewWidget)); > > + else > > + webkitWebViewBaseEnterFullScreen(WEBKIT_WEB_VIEW_BASE(m_viewWidget)); > > What... what could be a WebKitWebViewBase but not a WebKitWebView...? C API WKView, that's why we have WebKitWebViewBase. It's used by WTR and C API unit tests.
Carlos Garcia Campos
Comment 4 2017-06-10 23:30:23 PDT
Committed r218064: <http://trac.webkit.org/changeset/218064>
Note You need to log in before you can comment on or make changes to this bug.