Bug 173132 - [Win64] Build error when compiling PaintHooks.asm.
Summary: [Win64] Build error when compiling PaintHooks.asm.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks: 173308
  Show dependency treegraph
 
Reported: 2017-06-08 23:27 PDT by Per Arne Vollan
Modified: 2017-06-13 02:28 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.37 KB, patch)
2017-06-09 00:06 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (910.29 KB, application/zip)
2017-06-09 01:32 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-06-08 23:27:44 PDT
There seems to be too many include paths on the command line for ml64. According to the documentation, a maximum of 10 /I options is allowed. See https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx.
Comment 1 Per Arne Vollan 2017-06-09 00:06:31 PDT
Created attachment 312396 [details]
Patch
Comment 2 Build Bot 2017-06-09 01:32:22 PDT
Comment on attachment 312396 [details]
Patch

Attachment 312396 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3898614

New failing tests:
svg/animations/svglength-element-removed-crash.svg
Comment 3 Build Bot 2017-06-09 01:32:23 PDT
Created attachment 312410 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 4 Brent Fulgham 2017-06-09 08:45:28 PDT
Comment on attachment 312396 [details]
Patch

r=me
Comment 5 Per Arne Vollan 2017-06-09 08:50:33 PDT
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 312396 [details]
> Patch
> 
> r=me

Thanks for reviewing!
Comment 6 WebKit Commit Bot 2017-06-09 09:19:09 PDT
Comment on attachment 312396 [details]
Patch

Clearing flags on attachment: 312396

Committed r217988: <http://trac.webkit.org/changeset/217988>
Comment 7 WebKit Commit Bot 2017-06-09 09:19:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Alex Christensen 2017-06-09 10:17:38 PDT
Comment on attachment 312396 [details]
Patch

I think a better solution would have been something more like http://trac.webkit.org/r216332
Comment 9 Per Arne Vollan 2017-06-12 00:25:34 PDT
(In reply to Alex Christensen from comment #8)
> Comment on attachment 312396 [details]
> Patch
> 
> I think a better solution would have been something more like
> http://trac.webkit.org/r216332

Yes, it was probably not necessary to create a new library for just one asm file :)