Crash in -[WKWebView _initializeWithConfiguration:]
Created attachment 312374 [details] Patch
Comment on attachment 312374 [details] Patch Clearing flags on attachment: 312374 Committed r217967: <http://trac.webkit.org/changeset/217967>
All reviewed patches have been landed. Closing bug.
<rdar://problem/32664993>
Comment on attachment 312374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312374&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:140 > NSString *_overrideContentSecurityPolicy; Looks like this has exactly the same problem as _mediaContentTypesRequiringHardwareSupport. Would you fix that, or would you like me to do it? > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:141 > + RetainPtr<NSString> _mediaContentTypesRequiringHardwareSupport; The setter should copy the string, not just retain it.
(In reply to Darin Adler from comment #5) > Comment on attachment 312374 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312374&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:140 > > NSString *_overrideContentSecurityPolicy; > > Looks like this has exactly the same problem as > _mediaContentTypesRequiringHardwareSupport. Would you fix that, or would you > like me to do it? Sure I'll take care of it when I do the followup below: > > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:141 > > + RetainPtr<NSString> _mediaContentTypesRequiringHardwareSupport; > > The setter should copy the string, not just retain it. Good catch!
Reopening to attach new patch.
Created attachment 312484 [details] Follow-up Patch
Comment on attachment 312484 [details] Follow-up Patch Clearing flags on attachment: 312484 Committed r218021: <http://trac.webkit.org/changeset/218021>