Bug 173123 - Crash under -[WKWebView _updateVisibleContentRects]
Summary: Crash under -[WKWebView _updateVisibleContentRects]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-08 17:10 PDT by Simon Fraser (smfr)
Modified: 2017-06-08 17:47 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.41 KB, patch)
2017-06-08 17:11 PDT, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-06-08 17:10:02 PDT
Crash under -[WKWebView _updateVisibleContentRects]
Comment 1 Simon Fraser (smfr) 2017-06-08 17:11:14 PDT
Created attachment 312362 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-06-08 17:11:34 PDT
rdar://problem/32650112
Comment 3 Tim Horton 2017-06-08 17:15:53 PDT
Comment on attachment 312362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312362&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:319
> +- (BOOL)_isValid

Maybe adopt this in _webProcessIdentifier and _killWebProcess? This is definitely better than those, which don't do the nil check.
Comment 4 Simon Fraser (smfr) 2017-06-08 17:47:03 PDT
https://trac.webkit.org/r217956