Bug 173103 - [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
Summary: [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-08 09:19 PDT by Zan Dobersek
Modified: 2017-06-09 02:09 PDT (History)
2 users (show)

See Also:


Attachments
Patch (61.91 KB, patch)
2017-06-08 09:33 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (61.98 KB, patch)
2017-06-09 00:33 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (63.55 KB, patch)
2017-06-09 01:37 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (63.83 KB, patch)
2017-06-09 01:54 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-06-08 09:19:02 PDT
[WPE] Enable ENCRYPTED_MEDIA
Comment 1 Zan Dobersek 2017-06-08 09:33:51 PDT
Created attachment 312312 [details]
Patch
Comment 2 Michael Catanzaro 2017-06-08 17:54:24 PDT
Comment on attachment 312312 [details]
Patch

Either edit OptionsWPE.cmake as well to make the change for real, or change the commit message to "Enable ENCRYPTED_MEDIA on the bots" or "Enable ENCRYPTED_MEDIA when using build-webkit", something to indicate the change is only partial.
Comment 3 Zan Dobersek 2017-06-09 00:30:25 PDT
The feature isn't mature yet to expose the configuration option yet, so no need to add anything to OptionsWPE.cmake.
Comment 4 Zan Dobersek 2017-06-09 00:33:11 PDT
Created attachment 312402 [details]
Patch
Comment 5 Xabier Rodríguez Calvar 2017-06-09 00:59:52 PDT
Comment on attachment 312402 [details]
Patch

I think we should make the feature PUBLIC OFF at OptionsWPE.cmake
Comment 6 Zan Dobersek 2017-06-09 01:07:25 PDT
(In reply to Xabier Rodríguez Calvar from comment #5)
> Comment on attachment 312402 [details]
> Patch
> 
> I think we should make the feature PUBLIC OFF at OptionsWPE.cmake

OK. This would follow the MEDIA_SOURCE configuration flag.
Comment 7 Zan Dobersek 2017-06-09 01:37:16 PDT
Created attachment 312411 [details]
Patch for landing
Comment 8 Zan Dobersek 2017-06-09 01:54:47 PDT
Created attachment 312412 [details]
Patch for landing
Comment 9 Zan Dobersek 2017-06-09 02:09:18 PDT
Committed r217973: <http://trac.webkit.org/changeset/217973>