RESOLVED FIXED 173103
[WPE] Enable ENCRYPTED_MEDIA for build-webkit builds 
https://bugs.webkit.org/show_bug.cgi?id=173103
Summary [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
Zan Dobersek
Reported 2017-06-08 09:19:02 PDT
[WPE] Enable ENCRYPTED_MEDIA
Attachments
Patch (61.91 KB, patch)
2017-06-08 09:33 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (61.98 KB, patch)
2017-06-09 00:33 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (63.55 KB, patch)
2017-06-09 01:37 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (63.83 KB, patch)
2017-06-09 01:54 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-06-08 09:33:51 PDT
Created attachment 312312 [details] Patch
Michael Catanzaro
Comment 2 2017-06-08 17:54:24 PDT
Comment on attachment 312312 [details] Patch Either edit OptionsWPE.cmake as well to make the change for real, or change the commit message to "Enable ENCRYPTED_MEDIA on the bots" or "Enable ENCRYPTED_MEDIA when using build-webkit", something to indicate the change is only partial.
Zan Dobersek
Comment 3 2017-06-09 00:30:25 PDT
The feature isn't mature yet to expose the configuration option yet, so no need to add anything to OptionsWPE.cmake.
Zan Dobersek
Comment 4 2017-06-09 00:33:11 PDT
Created attachment 312402 [details] Patch
Xabier Rodríguez Calvar
Comment 5 2017-06-09 00:59:52 PDT
Comment on attachment 312402 [details] Patch I think we should make the feature PUBLIC OFF at OptionsWPE.cmake
Zan Dobersek
Comment 6 2017-06-09 01:07:25 PDT
(In reply to Xabier Rodríguez Calvar from comment #5) > Comment on attachment 312402 [details] > Patch > > I think we should make the feature PUBLIC OFF at OptionsWPE.cmake OK. This would follow the MEDIA_SOURCE configuration flag.
Zan Dobersek
Comment 7 2017-06-09 01:37:16 PDT
Created attachment 312411 [details] Patch for landing
Zan Dobersek
Comment 8 2017-06-09 01:54:47 PDT
Created attachment 312412 [details] Patch for landing
Zan Dobersek
Comment 9 2017-06-09 02:09:18 PDT
Committed r217973: <http://trac.webkit.org/changeset/217973>
Note You need to log in before you can comment on or make changes to this bug.